1433101 - Add a pref to control whether or how dispatch keypress event from TextEventDispatcher

Status: RESOLVED FIXED

(Core :: Widget, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Before working on bug 968056, we need to know we need to change how much keyboard event listeners. So, we should add a new pref into TextEventDispatcher.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d585b4df9731946328c5dae6553f03bc1d31398

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=983fe01ef82eef8ffcae722d8962b2f54af88419

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c15fdbff6eb1beeb7880259f5309e4e90cecde63

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fc696ae1e5be247282aad1252507a7b0199f2f8

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=68693242c1e6b142dec1b0ee57c126c499ee4fde

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b68ea1f8583774e64c54f9cea086ed06ff7b399

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1433101 - part 1: Add new pref which disables keypress event for non-printable keys only for the default event group in web content

UI Events declares that keypress event should be fired when the keypress event
causes some text input.  However, we're keeping our traditional behavior for
historical reasons because our internal event handlers (including event
handlers of Thunderbird) handles keypress events for any keys.  Therefore,
for minimizing the side effect, we should stop kicking keypress event handlers
in the default event group in web content.

This patch adds new pref for enabling the standard behavior in web content.

Additionally, creates WidgetKeyboardEvent::IsInputtingText() for sharing the
check logic between TextEventDispatcher and TextEditor/HTMLEditor.

Review commit: https://reviewboard.mozilla.org/r/215800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215800/

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

Attachment: Bug 1433101 - part 2: Treat Enter and Shift+Enter as printable key

Chromium dispatches a keypress event when pressing Enter or Shift+Enter.
Actually, when user press them in <pre> element of HTML editor, ﾂ･n is inserted.
It makes sense to treat the key combinations as inputting text.

Review commit: https://reviewboard.mozilla.org/r/215802/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/215802/

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(Away: -9/28)]

I was thinking that followup fixes mainly for automated tests should be reviewed by stone. However, as far as I know, he is not available now. So, I'm currently thinking that smaug needs to review them even though I know you're really busy. If you know some people who should review them, let me know.  Or, I'm a co-module owner of Event Handling, so, just fixing existing event handler may be able to reviewed by anybody?

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Happy to review

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8945668 [details]
Bug 1433101 - part 1: Add new pref which disables keypress event for non-printable keys only for the default event group in web content

https://reviewboard.mozilla.org/r/215800/#review221634

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8945669 [details]
Bug 1433101 - part 2: Treat Enter and Shift+Enter as printable key

https://reviewboard.mozilla.org/r/215802/#review221640

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81157078b090
part 1: Add new pref which disables keypress event for non-printable keys only for the default event group in web content r=smaug
https://hg.mozilla.org/integration/autoland/rev/34abf9793163
part 2: Treat Enter and Shift+Enter as printable key r=smaug

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/81157078b090
https://hg.mozilla.org/mozilla-central/rev/34abf9793163