1433413 - Optimize IsEventTargetChrome

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement, P2)

Description

[Olli Pettay [:smaug][[e-mail]]]

We could just QI to nsINode and get its owner doc. I don't see reason to QI to nsIDocument.
This would make mOnlySystemGroupDispatchInContent a tad less heavy.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: event_target_is_chrome_opt.diff

remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/fb71cc216b0aa23c4926c6aa3815e7afd7b8ee34
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb71cc216b0aa23c4926c6aa3815e7afd7b8ee34
remote: recorded changegroup in replication log in 0.067s

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Comment on attachment 8945753 [details] [diff] [review]
event_target_is_chrome_opt.diff

Looks fine to me.

However, this depends on this explanation:
>   /**
>    * Returns the "node document" of this node.
>    *
>    * https://dom.spec.whatwg.org/#concept-node-document
>    *
>    * Note that in the case that this node is a document node this method
>    * will return |this|.  That is different to the Node.ownerDocument DOM
>    * attribute (implemented by nsINode::GetOwnerDocument) which is specified to
>    * be null in that case:
>    *
>    * https://dom.spec.whatwg.org/#dom-node-ownerdocument
>    *
>    * For all other cases OwnerDoc and GetOwnerDocument behave identically.
>    */
>   nsIDocument *OwnerDoc() const
>   {
>     return mNodeInfo->GetDocument();
>   }
https://searchfox.org/mozilla-central/rev/11d0ff9f36465ce19b0c43d1ecc3025791eeb808/dom/base/nsINode.h#530-531

Although I don't like the method name...

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Yes, it depends on OwnerDoc() behaving consistently with all the nodes.
I've never liked .ownerDocument behavior in DOM spec.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df9df2ef6538
Optimize IsEventTargetChrome, r=masayuki

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/df9df2ef6538