1438097 - nsXBLWindowKeyHandler should wait reply from remote process even if the keyboard event won't be fired on content in the default event group

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Currently, nsXBLWindowKeyHandler::HandleEventOnCaptureInSystemEventGroup() doesn't wait reply for keyboard events which won't be fired on content in the default event group (i.e, its mFlags.mOnlySystemGroupDispatchInContent is true). This is reasonable if system event listeners in remote process won't consume any keyboard events before nsXBLWindowKeyHandleor. However, it may not be so.

So, nsXBLWindowKeyHandler::HandleEventOnCaptureInSystemEventGroup() should mark such events as "wants reply from remote process".

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=60bd70ca5c272cbbe50ef26e3d2e27c95d30b23c

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3fc4f4222fa0601dbd3c1ed43ffb474b36a51cf3

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Attachment: Bug 1438097 - nsXBLWindowKeyHandler::HandleEventOnCaptureInSystemEventGroup() should mark keyboard events which won't be fired on content in the default event group as "wait reply from remote process"

BaseEventFlags::mOnlySystemGroupDispatchInContent was used only when the
key combination is reserved by chrome, and used for preventing to fire
in web content on non-e10s window (bug 1203059).

However, now, this is also used for preventing to fire keypress event for
non-printable key combinations on web contents in the default event group
(bug 1433101).  Therefore, now, we need to send events whose
mFlags.mOnlySystemGroupDispatchInContent is true because some event listeners
in the system event group in remote process may want to handle specific
keyboard events before nsXBLWindowKeyHandler.

This patch makes nsXBLWindowKeyHandler::HandleEventOnCaptureInSystemEventGroup()
treat KeyboardEvent whose mFlags.mOnlySystemGroupDispatchInContent is true
but which will be sent to remote process as usual event.

Review commit: https://reviewboard.mozilla.org/r/220422/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220422/

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8951156 [details]
Bug 1438097 - nsXBLWindowKeyHandler::HandleEventOnCaptureInSystemEventGroup() should mark keyboard events which won't be fired on content in the default event group as "wait reply from remote process"

https://reviewboard.mozilla.org/r/220422/#review226450

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c25eaa199ff8
nsXBLWindowKeyHandler::HandleEventOnCaptureInSystemEventGroup() should mark keyboard events which won't be fired on content in the default event group as "wait reply from remote process" r=smaug

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c25eaa199ff8