879606 - Missing window border at the top of the window in restored mode for non-glass windows themes + LWT

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Justin Dolske [:Dolske]]

(Filed from Australis tabs ui-review #1)

XP Classic + LWT -- border on top of window missing? Seems like it's overlapping or something. See also bug 590945 -- when that's fixed, we'll actually _want_ to extend things to the edge (closer? all the way? not sure)

https://www.flickr.com/photos/12814025@N06/8951189417/in/set-72157633932643588

Comment 1

[Matthew N. [:MattN]]

See also bug 879600 which seems like the opposite problem but for maximized windows without LWT.

Comment 2

[:Gijs (he/him)]

Not taking for M7.

Comment 3

[:Gijs (he/him)]

On Nightly, we deal with this by having a titlebar in Classic mode when restored, which means we don't have any issues. I think we probably want to avoid doing that if possible. Is there a value for chromemargin we could use to get just the top window border, but not the titlebar? I've tried just using background positioning or margins or such, but that doesn't help because the LWT also specifies a background color, and the main window seems to treat margin and padding the same (that is, backgrounds get drawn in them anyway). Alternatively, we could try to fake the border with CSS, but I'm not sure how much I like that idea.

Dao, do you have an idea what we could do here?

Comment 4

[Dão Gottwald [:dao]]

(In reply to :Gijs Kruitbosch from comment #3)
> Is there a value for chromemargin we could use
> to get just the top window border, but not the titlebar?

I don't think so.

> I've tried just
> using background positioning or margins or such, but that doesn't help
> because the LWT also specifies a background color, and the main window seems
> to treat margin and padding the same (that is, backgrounds get drawn in them
> anyway).

Right, that's not going to work either.

I see no option other than drawing the title bar or faking the border.

This bug actually affects pretty every Windows theme except for Glass where we already deal with it, right?

Comment 5

[:Gijs (he/him)]

(In reply to Dão Gottwald [:dao] from comment #4)
> This bug actually affects pretty every Windows theme except for Glass where
> we already deal with it, right?

Looks like it, yes. I've adjusted the summary accordingly.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Hm - I personally don't think this bug is severe enough to be P1. P2 or P3 maybe, but not P1.

Downgrading priority until further notice.

Comment 7

[:Gijs (he/him)]

Stealing.

Comment 8

[:Gijs (he/him)]

Attachment: add window border in classic mode,

So this isn't too hard on classic mode. This produces the right result, even with non-default colors. However, this doesn't work on XP modern themes, which is why I stuck it in a classic-only media query. Unfortunately, AFAICT there's no way to get the window border colors for modern themes - the CSS colors I use here simply lieand return grey values (I realize that I'm using the ThreeD ones explicitly here, because those make up the outer border on classic). I suspect we'll need to hardcode something that works for the three XP modern values and put those in media queries too, ugly though it is. What we'd do for custom themes with an lwtheme, I'm not sure about.

Comment 9

[:Gijs (he/him)]

Attachment: Screen Shot with patch + lwt + XP classic

Comment 10

[:Gijs (he/him)]

https://hg.mozilla.org/projects/ux/rev/9fd9f974e727

Comment 11

[:Gijs (he/him)]

Attachment: draw top window border for XP modern themes when lwtheme is active,

Well, that was more of a pain than I expected. I'll put up screenshots in a bit.

Comment 12

[:Gijs (he/him)]

Attachment: screenshot-borders.png

Well, that took longer than I thought it would.

Note that you can sort of see the edge of the titlebar still being drawn on the side borders of the window. It's especially visible in the luna-silver focused window. That's a Windows or Core thing we can't really fix, though, and it happens if we don't fix this, too, so I'd like to still take this.

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 818420 [details] [diff] [review]
draw top window border for XP modern themes when lwtheme is active,

Review of attachment 818420 [details] [diff] [review]:
-----------------------------------------------------------------

There's no proper spec for these colors, so I'd at least like to run this by Stephen (if he has the time, hence f? not r?).

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 818420 [details] [diff] [review]
draw top window border for XP modern themes when lwtheme is active,

Review of attachment 818420 [details] [diff] [review]:
-----------------------------------------------------------------

Gijs, feel free to go ahead and land and then we can file a follow-up to tweak the colors if necessary.

Comment 15

[:Gijs (he/him)]

https://hg.mozilla.org/projects/ux/rev/ef2d420ecc1a

Comment 16

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/9fd9f974e727
https://hg.mozilla.org/mozilla-central/rev/ef2d420ecc1a