1567695 - Port bug 1566457: Can't open Error Console: Tools > Developer Tools > Error Console (or Ctrl+Shift+J)

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Jonathan Kamens]

Neither Ctrl-Shift-J nor Tools | Developer Tools | Error Console opens the error console.

Regression:

3:18.86 INFO: Running comm-central build built on 2019-07-18 18:44:08.424000, revision dcddacbb
3:31.14 INFO: application_buildid: 20190718180900
3:31.14 INFO: application_changeset: dcddacbba74a6eed9045c73a31dca3031fb79187
3:31.14 INFO: application_name: Thunderbird
3:31.14 INFO: application_repository: https://hg.mozilla.org/comm-central
3:31.14 INFO: application_version: 70.0a1
3:49.18 INFO: No more inbound revisions, bisection finished.
3:49.18 INFO: Last good revision: dcddacbba74a6eed9045c73a31dca3031fb79187
3:49.18 INFO: First bad revision: 6073880430358dae3e374bf96b5662c451b7d045
3:49.18 INFO: Pushlog:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=dcddacbba74a6eed9045c73a31dca3031fb79187&tochange=6073880430358dae3e374bf96b5662c451b7d045

Though I suppose it's possible that the issue is in mozilla-central, not comm-central, in which case the regression above might help determine timing but not with the actual cause of the issue.

Comment 1

[Richard Marti (:Paenglab)]

It's only the Error Console that doesn't open. The Developer Toolbox or the Scratchpad still open.

When I try to open the error console, I get:

TypeError: devtools is undefined mailWindowOverlay.js:39:5

Comment 2

[Jorg K (CEST = GMT+2)]

Alice, can you get us the M-C range here.
STR: Tools > Developer Tools > Error Console (or Ctrl+Shift+J) doesn't work.

Comment 3

[Alice0775 White]

TypeError: devtools is undefined mailWindowOverlay.js:39:5
get chrome://messenger/content/mailWindowOverlay.js:39
toJavaScriptConsole chrome://messenger/content/mailCore.js:399
oncommand chrome://messenger/content/messenger.xul:1

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=dcddacbba74a6eed9045c73a31dca3031fb79187&tochange=6073880430358dae3e374bf96b5662c451b7d045
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ca1dbd076e1e47a8616ab6ee3e6fd4083d576857&tochange=bc0fdcef296f2d429e3f4b5f29e264ffc185163d

Comment 4

[Jorg K (CEST = GMT+2)]

Thank you so much Alice:
https://hg.mozilla.org/mozilla-central/rev/271d26f3907ee769e194cec57b6662a08f89d34e#l1.15

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1567695-loader.patch

This works. I have no insight into the inner working, so let's see what the reviewer thinks about this.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7d4f49bb227f
Port bug 1566457: devtools is no longer exported from Loader.jsm. rs=bustage-fix

Comment 7

[Geoff Lankow (:darktrojan)]

Comment on attachment 9079599 [details] [diff] [review]
1567695-loader.patch

Review of attachment 9079599 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 8

[Geoff Lankow (:darktrojan)]

Attachment: 1567695-devtools-loader.diff

There's another one. Reusing this bug since it's exactly the same cause and fix.

Comment 9

[Jorg K (CEST = GMT+2)]

Comment on attachment 9081180 [details] [diff] [review]
1567695-devtools-loader.diff

Uff, I missed that one. Given that we're still in the 70 cycle, it's fine to reuse the bug.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/aff1a2d1a523
Port bug 1566457: devtools is no longer exported from Loader.jsm, take 2. r=jorgk