1566457 - Loaders summer cleanup

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement)

Description

[Alexandre Poirot [:ochameau]]

Loader.jsm and base-loader are full of unused features / code branches which are far from being obvious.

These two modules could be shorter and slightly easier to process.
I'll attach here random patches doing quite random cleanups but mostly focusing on removing unused code.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1566457 - Remove unused codepath in the base loader for non-shared globals.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1566457 - Remove unused devtools-cleanup observer message.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1566457 - Only export require, loader and DevToolsLoader from Loader.jsm

The rest was legacy code to support old xul add-ons.
All mozilla-central code used to be refactored, but a few places
were still using the old codepaths.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1566457 - Remove unused provider logic from Loader.jsm.

We used to have another provider which would load module via file:// URI,
directly from the disk. But the progress on artifact builds and ./mach build faster
made this obsolete and has been removed a long time ago.
We still have a lot of abstraction to support this non-existent feature.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1566457 - Removed deprecated gDevTools JSM.

This was kept to support old xul addons. All mozilla-central usages
have been removed and now uses Loader.jsm to get access to this module.

Comment 6

[Julian Descottes [:jdescottes]]

Hi Mark,

In this patch series we are updating a few JSMs, do we need to update https://searchfox.org/mozilla-central/source/tools/lint/eslint/modules.json manually to reflect the changes?

Comment 7

[Mark Banner (:standard8)]

(In reply to Julian Descottes [:jdescottes] from comment #6)

In this patch series we are updating a few JSMs, do we need to update https://searchfox.org/mozilla-central/source/tools/lint/eslint/modules.json manually to reflect the changes?

Yes there's only manual changes to that file at the moment, although we were also hoping that with some of the moves towards es6 modules that might go away sometime.

For now, its manual changes, but you only need to list JSMs where there's more than one export, or the exported name is different from the filename.

Comment 8

[Julian Descottes [:jdescottes]]

Thanks for the feedback!

Comment 9

[Alexandre Poirot [:ochameau]]

Thanks for the review Julian, I tweaked the json file.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=92809d4502696cf4ecf38aadbc9896f328cdf590

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d45b2bb978de
Remove unused codepath in the base loader for non-shared globals. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/a3d95f00472e
Remove unused devtools-cleanup observer message. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/271d26f3907e
Only export require, loader and DevToolsLoader from Loader.jsm r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/84c2a0655cf3
Remove unused provider logic from Loader.jsm. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/9ea86b530d01
Removed deprecated gDevTools JSM. r=jdescottes

Comment 11

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/d45b2bb978de
https://hg.mozilla.org/mozilla-central/rev/a3d95f00472e
https://hg.mozilla.org/mozilla-central/rev/271d26f3907e
https://hg.mozilla.org/mozilla-central/rev/84c2a0655cf3
https://hg.mozilla.org/mozilla-central/rev/9ea86b530d01