994592 - [css-grid] Remove grid-auto-flow:none, add grid-auto-flow:stack

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Simon Sapin (:SimonSapin)]

https://dvcs.w3.org/hg/csswg/rev/066b11142b52

Comment 1

[Mats Palmgren (inactive)]

Attachment: fix

https://tbpl.mozilla.org/?tree=Try&rev=f86b02375dfd

Comment 2

[Mats Palmgren (inactive)]

I spawned off bug 1005567 for removing 'grid-auto-position'.

Comment 3

[Simon Sapin (:SimonSapin)]

Comment on attachment 8416971 [details] [diff] [review]
fix

Review of attachment 8416971 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the comments addressed:

::: layout/style/nsCSSParser.cpp
@@ +7831,5 @@
>      return false;
>    }
>  
> +  // If the value starts with a 'stack', 'dense', 'column' or 'row' keyword,
> +  // it can only start with a <'grid-auto-flow'>.

While you’re touching this, could you fix this comment? It should express equivalence rather than just implication:

 // The values starts with a <'grid-auto-flow'> if and only if
 // it starts with a 'stack', 'dense', 'column' or 'row' keyword.

::: layout/style/test/property_database.js
@@ +4817,5 @@
>  			"row dense",
>  			"dense column",
>  			"dense row",
> +			"stack column",
> +			"stack row",

Please add "stack" by itself.

Comment 4

[Mats Palmgren (inactive)]

With the nits fixed as suggested:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a07ce7d79a6c

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a07ce7d79a6c

Comment 6

[Kohei Yoshino [:kohei]]

This is still disabled by default, won't affect site compat.