Closed
Bug 991738
Opened 12 years ago
Closed 12 years ago
Fix "test_markpageas.js" before switching Task.jsm to use Promise.jsm
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: Paolo, Assigned: Paolo)
References
Details
Attachments
(1 file)
|
4.03 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
This patch cleans up the Places test named "test_markpageas.js".
This is required before switching Task.jsm to use Promise.jsm.
Attachment #8401352 -
Flags: review?(mak77)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 8401352 [details] [diff] [review]
The patch
Review of attachment 8401352 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/components/places/tests/unit/test_markpageas.js
@@ +22,5 @@
> + let completionPromise = new Promise(resolveCompletionPromise => {
> + observer = {
> + _visitCount: 0,
> + onBeginUpdateBatch: function () {},
> + onEndUpdateBatch: function() {},
may use NavHistoryObserver.prototype
Attachment #8401352 -
Flags: review?(mak77) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Pushed with the suggested change:
https://hg.mozilla.org/integration/fx-team/rev/069251b56355
|
||
Comment 3•12 years ago
|
||
Assignee: nobody → paolo.mozmail
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•