927610 - Get rid of NS_ERROR_TYPE_ERR

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P5)

Description

[Masatoshi Kimura [:emk]]

This is confusing and sometimes misused (see bug 926890).

Comment 1

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.

Comment 2

[Boris Zbarsky [:bzbarsky]]

We should fix this, imo.  It's causing us to have spec-compliance bugs because people get confused and use NS_ERROR_TYPE_ERR.  See bug 1472095.

We need to kill NS_ERROR_DOM_TYPE_ERR too...

Comment 3

[Boris Zbarsky [:bzbarsky]]

I filed bug 1581172 on NS_ERROR_DOM_TYPE_ERR.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 927610 part 1. Stop using NS_ERROR_TYPE_ERR in UDPSocket. r=smaug

The only ways DispatchReceivedData can fail are if our scope is torn down, we
OOM when creating a typed array, or we fail to queue a runnable. These all
seem like pretty unexpected situations, so NS_ERROR_UNEXPECTED seems
appropriate if we don't want to just propagate through the error from
DispatchReceivedData.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 927610 part 2. Stop using NS_ERROR_TYPE_ERR in windowutils. r=smaug

The actual return code we return here doesn't really matter, since there is
already an exception on the JSContext. NS_ERROR_UNEXPECTED is as good as
anything, since we don't expect bogus options.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 927610 part 3. Stop using NS_ERROR_TYPE_ERR in serviceworker code. r=smaug

NS_ERROR_DOM_TYPE_ERR is not much better, but this at least allows us to get
rid of NS_ERROR_TYPE_ERR completely...

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/578478de9488
part 1.  Stop using NS_ERROR_TYPE_ERR in UDPSocket.  r=smaug
https://hg.mozilla.org/integration/autoland/rev/857146a2bb00
part 2.  Stop using NS_ERROR_TYPE_ERR in windowutils.  r=smaug
https://hg.mozilla.org/integration/autoland/rev/93327435846a
part 3.  Stop using NS_ERROR_TYPE_ERR in serviceworker code.  r=smaug

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/578478de9488
https://hg.mozilla.org/mozilla-central/rev/857146a2bb00
https://hg.mozilla.org/mozilla-central/rev/93327435846a