908232 - WebGL2 RASTERIZER_DISCARD tracking

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Guillaume Abadie]

Track RASTERIZER_DISCARD and generate warning if enabled and calling rasterizer related function.

Comment 1

[Guillaume Abadie]

Attachment: patch step 1 - revision 1: state tracking refactor

Comment 2

[Guillaume Abadie]

Attachment: patch step 2 - revision 2: Add RASTERIZER_DISCARD tracking

This patch also fix a bug when calling ForceClearFramebufferWithDefaultValues while RASTERIZER_DISCARD is enabled.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 794114 [details] [diff] [review]
patch step 1 - revision 1: state tracking refactor

Review of attachment 794114 [details] [diff] [review]:
-----------------------------------------------------------------

This is nice.

Comment 4

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 794119 [details] [diff] [review]
patch step 2 - revision 2: Add RASTERIZER_DISCARD tracking

Review of attachment 794119 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLContextFramebufferOperations.cpp
@@ +24,5 @@
>  
>      if (mask == 0) {
>          GenerateWarning("Calling gl.clear(0) has no effect.");
> +    } else if (mRasterizerDiscardEnabled) {
> +        GenerateWarning("Calling gl.clear() with RASTERIZER_DISCARD enabled has no effects.");

Nice!

Comment 5

[Guillaume Abadie]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2aea1fd9522d
https://hg.mozilla.org/integration/mozilla-inbound/rev/fba54a00792c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2aea1fd9522d
https://hg.mozilla.org/mozilla-central/rev/fba54a00792c