889699 - Erroneously reports being able to play h264 with gstreamer backend.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Needs to check not only that gstreamer is installed but that gstreamer can play h264 and report the canPlayType correctly. See bug 887137 causing confusion.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Maybe some web console logging or other UI would help here too.

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: Fix

Comment 3

[Alessandro Decina]

Comment on attachment 776134 [details] [diff] [review]
Fix

Review of attachment 776134 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, thanks!

::: content/media/gstreamer/GStreamerFormatHelper.cpp
@@ +145,5 @@
> +
> +      if (!tmp) {
> +        gst_caps_unref(caps);
> +        continue;
> +      }

This can only happen if there's a typo in sDefaultCodecCaps[i][1] right? If so please remove it since it's defensive code that can mask bugs.

Comment 4

[Mike Hommey [:glandium]]

Backed out for Linux mochitest crashes
https://tbpl.mozilla.org/php/getParsedLog.php?id=25474083&tree=Mozilla-Inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b4e29861bef

Comment 5

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

+ null check; carry over r+

https://hg.mozilla.org/integration/mozilla-inbound/rev/e11fd10615c7

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e11fd10615c7