887908 - There are two close buttons for sidebars

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: 2 close buttons for sidebars

See attached screen shot.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Note that this appears to be a Retina-only bug.

Comment 2

[:Gijs (he/him)]

Stealing this

Comment 3

[:Gijs (he/him)]

Attachment: Patch v1

This works for me, and is net code-removal, too! Hurray? :-)

The slightly sad bit about this is that the close-sidebar.png image is now wholly unused on browser - but after a quick check of comm-central, still used by calendar/ (possibly amongst others? Thunderbird?), so removing it from toolkit before we have done the merge-that-wont-be-backed-out is probably not a workable idea.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 773907 [details] [diff] [review]
Patch v1

Review of attachment 773907 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for catching this. :) Fix looks good to me.

Comment 5

[:Gijs (he/him)]

https://hg.mozilla.org/projects/ux/rev/47dbbf9e4c5d

Comment 6

[Dão Gottwald [:dao]]

(In reply to :Gijs Kruitbosch from comment #3)
> The slightly sad bit about this is that the close-sidebar.png image is now
> wholly unused on browser - but after a quick check of comm-central, still
> used by calendar/ (possibly amongst others? Thunderbird?), so removing it
> from toolkit before we have done the merge-that-wont-be-backed-out is
> probably not a workable idea.

File a bug on removing it then?

Comment 7

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/47dbbf9e4c5d