882817 - [webvtt] Fix assertion errors on debug builds for the new tests

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Rick Eyre (:reyre)]

We're currently getting some assertion errors that we aren't expecting when we run our tests in the test suite.

https://tbpl.mozilla.org/?tree=Try&rev=449474f24c45

This is happening when we check the content load policy for the HTMLTrackElement. We pass in the HTMLTrackElement as an argument, but later Gecko seems to think it's not a window or DOM node and an assertion is thrown.

Comment 1

[Rick Eyre (:reyre)]

Attachment: v1: Fix QI implementation of HTMLTrackElement

https://tbpl.mozilla.org/?tree=Try&rev=9f09df497708

The new tests don't show up in the try changesets added, but if you go to the log you can see them being run.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 762454 [details] [diff] [review]
v1: Fix QI implementation of HTMLTrackElement

r=me

Comment 3

[Rick Eyre (:reyre)]

Attachment: v1: Fix QI implementation of HTMLTrackElement r=bz

Just updated the commit message to include r=bz

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/229c4d26630e

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 762460 [details] [diff] [review]
v1: Fix QI implementation of HTMLTrackElement r=bz

Review of attachment 762460 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/src/HTMLTrackElement.cpp
@@ +94,3 @@
>  
>  NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED(HTMLTrackElement)
>    NS_INTERFACE_MAP_ENTRY(nsIDOMHTMLElement)

NS_HTML_CONTENT_INTERFACES already deals with nsIDOMHTMLElement so this line is unnecessary.

Comment 6

[Rick Eyre (:reyre)]

Do you want to back this out of the tree then or just a forward fix?

Comment 7

[Rick Eyre (:reyre)]

Peter has recommended on IRC that we can just do a fix in the future. I'll open a bug for that and try to have a patch for it today.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/229c4d26630e