869069 - Use correct default item set for menu panel, and remove dummy widgets

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 745940 [details] [diff] [review]
Patch v1

How's my driving?

Comment 3

[u428464]

Does this also cover removing the dupe widgets (cut/copy/paste, Zoom) and the "activity" indicator ?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

(In reply to Guillaume C. [:ge3k0s] from comment #3)
> Does this also cover removing the dupe widgets (cut/copy/paste, Zoom) and
> the "activity" indicator ?

I only meant to remove the obviously dummy widgets in this patch (the demo widgets that don't really do anything), and make the default set in the panel more or less work as expected.

For Cut/Copy/Paste, we still need to de-dupe those, and nobody has started on that yet. I think we should leave them for now. For the activity throbber... maybe we could remove that at the same time as the old cut/copy/paste buttons. A general clean-out. :)

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 745940 [details] [diff] [review]
Patch v1

Review of attachment 745940 [details] [diff] [review]:
-----------------------------------------------------------------

Siri, please call 1-800-SAF-DRVR.
** Calling 1-800-SAF-DRVR **
"Hello, welcome to the safe driver hotline. How can I help you?"
I'd like to report that :mconley is a safe driver. That is all.
"Thank you, have a nice day"

r=me

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Woo! Thanks for the quick turnaround time!

https://hg.mozilla.org/projects/jamun/rev/8791cdcd0758

\o/

Comment 7

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/8791cdcd0758