850713 - Bump the minimum android ndk version to 9 (2.3)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Paul Adenot (:padenot)]

Attachment: patch

We need that so we have the SLES/OpenSLES.h header when building.

libopensl.so is dlopened anyways, so it works on 2.2 (tested on both a 2.2 and a 4.2 device)

Not sure what we should do with the old "android-version=5" references here:

http://mxr.mozilla.org/mozilla-central/source/nsprpub/configure.in#114
http://mxr.mozilla.org/mozilla-central/source/nsprpub/configure#22

Maybe we don't care for now.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=534f8398f6f2

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Paul Adenot (:padenot) from comment #0)
> Not sure what we should do with the old "android-version=5" references here:
> 
> http://mxr.mozilla.org/mozilla-central/source/nsprpub/configure.in#114
> http://mxr.mozilla.org/mozilla-central/source/nsprpub/configure#22
> 
We should, mind putting that patch together and getting review from ted?

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 724447 [details] [diff] [review]
patch

Review of attachment 724447 [details] [diff] [review]:
-----------------------------------------------------------------

green try run (on tegras running 2.2) is good enough for me

Comment 3

[Paul Adenot (:padenot)]

Attachment: Make NDK version 9 the default in the nsprpub directory. r=

Comment 4

[Mike Hommey [:glandium]]

(In reply to Brad Lassey [:blassey] from comment #1)
> (In reply to Paul Adenot (:padenot) from comment #0)
> > Not sure what we should do with the old "android-version=5" references here:
> > 
> > http://mxr.mozilla.org/mozilla-central/source/nsprpub/configure.in#114
> > http://mxr.mozilla.org/mozilla-central/source/nsprpub/configure#22
> > 
> We should, mind putting that patch together and getting review from ted?

No we shouldn't. NSPR doesn't need version 9, no need to change its default.

Comment 5

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0b147c3f682b

Comment 6

[Matthew Gregan [:kinetik]]

Comment on attachment 724543 [details] [diff] [review]
Make NDK version 9 the default in the nsprpub directory. r=

Obsoleting NSPR patch since it's not needed.

Comment 7

[Matthew Gregan [:kinetik]]

Backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2850e56ee75d

Failed during nsprpub configure:

checking whether the i686-pc-linux-gnu compiler (gcc    ) works... 
configure: error: installation or configuration problem: i686-pc-linux-gnu compiler gcc cannot create executables.
configure: error: /builds/slave/m-in-and-a6-000000000000000000/build/nsprpub/configure failed for nsprpub
*** Fix above errors and then restart with               "make -f client.mk build"
make[2]: Leaving directory `/builds/slave/m-in-and-a6-000000000000000000/build'
make[2]: *** [configure] Error 1
make[1]: *** [obj-firefox/config.status] Error 2
make[1]: Leaving directory `/builds/slave/m-in-and-a6-000000000000000000/build'
make: *** [build] Error 2

Comment 8

[Matthew Gregan [:kinetik]]

Relanded with clobber:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f8791dc5d90

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7f8791dc5d90

Comment 10

[Gian-Carlo Pascutto [:gcp]]

As somewhat expected, this *will* break Android 2.2 devices if you accidentally end up using a libc function that's not in android-8:

04-12 15:16:57.483 E/GeckoLinker(21708): /data/app/org.mozilla.fennec-1.apk!/libxul.so: Error: relocation to NULL @0x017aae84 for symbol "pthread_rwlock_unlock"

Luckily try still uses Android 2.2 devices :)

Comment 11

[(not currently active) Ted Mielczarek]

Note that we may in the near future move away from the Tegras running Android 2.2 to Pandaboards running 2.3, which means we'll lose this safety net.

If we intend to seriously support Android 2.2 we should figure out a way to avoid these dependencies.

Comment 12

[Kevin Brosnan [Ex-Mozilla]]

Android 2.2 is currently at 7% market share down from ~30% a year ago. http://developer.android.com/about/dashboards/index.html It may make sense to move it to a tier 2 or 3 support level in the near future.

Comment 13

[Gian-Carlo Pascutto [:gcp]]

Given that we'll be leaving those users behind I think this should be on an ESR release. (Firefox 24?)

Comment 14

[Kevin Brosnan [Ex-Mozilla]]

We don't do or release ESR Android builds.

Comment 15

[Mike Hommey [:glandium]]

(In reply to Kevin Brosnan [:kbrosnan] from comment #12)
> Android 2.2 is currently at 7% market share down from ~30% a year ago.
> http://developer.android.com/about/dashboards/index.html It may make sense
> to move it to a tier 2 or 3 support level in the near future.

Note this dashboard is a lie since this month, where they changed what it represents. It used to represent shipped devices or something along these lines, and it now represents devices accessing google play, which, subtly, is not exactly the same thing. That led to a big bump up for ICS and JB and down for older releases.

Comment 16

[Kevin Brosnan [Ex-Mozilla]]

This is turning into a discussion. --> https://mail.mozilla.org/listinfo/mobile-firefox-dev