830618 - Defect - Give site authors the ability to link Windows store apps w/ their page for IE10 parity

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect, P2)

Description

[Brian R. Bondy [:bbondy]]

IE10 can link HTML5 app w/ a page, "Get app for this site".
This would probably add a menu item to one of the appbar icons.

<meta name="msApplication-ID" content="App"/>
<meta name="msApplication-PackageFamilyName" content="ZeptoLabUKLimited.CutTheRope_sq9zxnwrk84pj"/>

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: images.jpg

There is text needed for the menu "Get app for this site" so if we want this later it can't be uplifted past mozilla-central.  Attached a screenshot of how it looks in IE.

Comment 2

[Brian R. Bondy [:bbondy]]

kjozwiak this is probably a good bug for you if you're interested. I think we'd just show/hide the menu item depending on if the site has meta tags in it.  See the attachment image in Comment 1. 

You'd check for these meta tags "msApplication-ID", and "msApplication-PackageFamilyName" which look like this in the head of the current page:

<meta name="msApplication-ID" content="microsoft.build.App" />
<meta name="msApplication-PackageFamilyName" content="microsoft.build_8wekyb3d8bbwe"/>

And if they exist, then you'd selectively show/hide the menu item in the appbar settings icon.

If the menu is clicked you'd open the link, something like this:
location.href = "ms-windows-store:PDP?PFN=microsoft.build_8wekyb3d8bbwe"

Comment 3

[Kamil Jozwiak [:kjozwiak]]

Sounds good, thanks Brian! Appreciate it.

I will start this one when I am finished with Bug 885383 which should be completed by this week.

Comment 4

[Jim Mathies [:jimm]]

We'd really really like a patch, but won't block on this. :)

Comment 5

[Kamil Jozwiak [:kjozwiak]]

Attachment: detecting meta tags

work in progress: code to detect meta tags

Comment 6

[Kamil Jozwiak [:kjozwiak]]

Attachment: Current WIP

Attached current WIP

Comment 7

[Kamil Jozwiak [:kjozwiak]]

Attachment: Checking meta data then adds appropriate menu entry that takes user to MS store

Went through testing and everything seems like its working:
- Ensured that the menu item doesn't appear when the meta data isn't found (tried several popular websites)
- Ensured that the menu item appeared correctly when the appropriate meta data was found
- Ensured that clicking on the menu item took the user to the MS store and displayed the correct application
- Ensured that the other menu items still worked without any issues

You can use this page that I created for testing:
https://s3.amazonaws.com/coding/METAdisabled.html

Comment 8

[Kamil Jozwiak [:kjozwiak]]

Forgot to add the page that has META data, this will open the "Cut the Rope" game in the MS store:

https://s3.amazonaws.com/coding/METAenabled.html

Comment 9

[Kamil Jozwiak [:kjozwiak]]

Attachment: menu item under firefox metro

Yuan, please let me know if you would like this changed. Used the same label as the original screenshot Brian added.

Comment 10

[Jim Mathies [:jimm]]

Comment on attachment 810336 [details] [diff] [review]
Checking meta data then adds appropriate menu entry that takes user to MS store

Review of attachment 810336 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/ContextCommands.js
@@ +265,5 @@
> +      Browser.selectedBrowser.contentWindow.document.location = storeLink;
> +    }
> +  },
> +
> +  getStoreLink: function cc_getStoreLink() {

you might want to add a comment header here explaining what this is about.

::: browser/metro/locales/en-US/chrome/browser.dtd
@@ +16,5 @@
>  <!ENTITY appbarErrorConsole.label   "Open error console">
>  <!ENTITY appbarJSShell.label        "Open JavaScript shell">
>  <!ENTITY appbarFindInPage2.label    "Find in page">
>  <!ENTITY appbarViewOnDesktop2.label "View on desktop">
> +<!ENTITY appbarMSMetaData2.label "Get app for this site">

nit - line up

Comment 11

[Kamil Jozwiak [:kjozwiak]]

Attachment: added the needed changes

Jim, could you push to the try server?

Comment 12

[Jim Mathies [:jimm]]

sure - 

https://tbpl.mozilla.org/?tree=Try&rev=e4f7dc4299b6

Comment 13

[Kamil Jozwiak [:kjozwiak]]

fx-team

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/ae03c0e61c14

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ae03c0e61c14