824654 - e:/builds/moz2_slave/m-cen-w64/build/layout/style/nsCSSParser.cpp(5698) : error C2079: 'compound' uses undefined class '`anonymous-namespace'::CSSParserImpl::nsAutoParseCompoundProperty'

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Makoto Kato [:m_kato]]

Duplicated nsAutoParseCompoundProperty definition causes bustage on Win64 builder.  Although this is tier-3 platform, we should fix this.

https://tbpl.mozilla.org/php/getParsedLog.php?id=18239760&tree=Firefox&full=1#error0

e:/builds/moz2_slave/m-cen-w64/build/layout/style/nsCSSParser.cpp(5698) : error C2079: 'compound' uses undefined class '`anonymous-namespace'::CSSParserImpl::nsAutoParseCompoundProperty'

e:/builds/moz2_slave/m-cen-w64/build/layout/style/nsCSSParser.cpp(5698) : error C2440: 'initializing' : cannot convert from '`anonymous-namespace'::CSSParserImpl *const ' to 'int'

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

we should remove duplicated define.

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 695697 [details] [diff] [review]
fix

Maybe I meant to write nsAutoFailingSupportsRule?  I guess that class didn't need to be a friend of CSSParserImpl in the first place.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 695697 [details] [diff] [review]
fix

The second instances was meant to be nsAutoFailingSupportsRule, I think.

Comment 4

[Cameron McCormack (:heycam)]

So I'm not actually sure why nsAutoFailingSupportsRule doesn't need to be a friend of CSSParserImpl, given it touches the latter's protected mInFailingSupportsRule member.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Because |friend|-ness of nested classes is implied in C++2011 (and was implemented well before 2011), even though it was not implied in C++1998.  So the friend declaration may well be needed for correct C++1998 compilers.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Anyway, I didn't mean to remove the review+, though I think you should probably change it to what was intended rather than removing it.

Comment 7

[Cameron McCormack (:heycam)]

Comment on attachment 695697 [details] [diff] [review]
fix

OK, let's add the friend declaration back in then.

Comment 8

[Makoto Kato [:m_kato]]

Attachment: fix v2

back nsAutoFailingSupportsRule define.

Comment 9

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/18a3309af87e

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/18a3309af87e