Closed
Bug 758297
Opened 13 years ago
Closed 13 years ago
Move browser element code to dom/browser-element
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)
References
Details
Attachments
(1 file)
|
9.26 KB,
patch
|
mounir
:
review+
|
Details | Diff | Splinter Review |
We already have our own test directory and three source files (after bug 741587). I'm about to add a fourth. I think it's time to move this code out of dom/base.
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Comment 2•13 years ago
|
||
Tested by doing a clobber build and running the browser-element tests.
|
|
Assignee | |
Updated•13 years ago
|
Attachment #626897 -
Flags: review?(mounir)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 626897 [details] [diff] [review]
Patch v1
Review of attachment 626897 [details] [diff] [review]:
-----------------------------------------------------------------
I would have preferred this schema:
dom/browser-element/src
dom/browser-element/tests
(dom/browser-element/interfaces)
But if you prefer to not have a dedicated src/ dir, I will not bother you ;)
Attachment #626897 -
Flags: review?(mounir) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
> But if you prefer to not have a dedicated src/ dir, I will not bother you ;)
Thanks. :)
|
|
Assignee | |
Comment 5•13 years ago
|
||
Assignee: nobody → justin.lebar+bug
Target Milestone: --- → mozilla16
|
||
Comment 6•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c84a182666fd
(Merged by Ed Morley)
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•