717871 - [SeaMonkey] mochitest-plain-5: "test_contextmenu_nested.xul | finished in a non-clean fashion" (in /tests/toolkit/components/satchel/test/test_privbrowsing.html)

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1326430863.1326431795.7896.gz
OS X 10.6 comm-central-trunk debug test mochitests-5/5 on 2012/01/12 21:01:03
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1326430559.1326431467.7607.gz
OS X 10.5 comm-central-trunk debug test mochitests-5/5 on 2012/01/12 20:55:59
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1326434859.1326435851.14912.gz
WINNT 5.2 comm-central-trunk debug test mochitests-5/5 on 2012/01/12 22:07:39
{
9598 INFO TEST-UNEXPECTED-FAIL | /tests/toolkit/content/tests/widgets/test_contextmenu_nested.xul | finished in a non-clean fashion (in /tests/toolkit/components/satchel/test/test_privbrowsing.html)
}

Bug 668728 caused/exposed this...

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 588444 [details] [diff] [review]
Patch (v1)

Review of attachment 588444 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/passwordmgr/test/test_privbrowsing.html
@@ +228,5 @@
>  
>  
>  var pb = get_PBSvc();
>  if (!pb) { // Private Browsing might not be available
>    ok(true, "Private browsing service is not available");

Nit: while there, could you use "todo(false", in both test?

Comment 3

[(no longer active)]

(In reply to Serge Gautherie (:sgautherie) from comment #2)
> Comment on attachment 588444 [details] [diff] [review]
> Patch (v1)
> 
> Review of attachment 588444 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: toolkit/components/passwordmgr/test/test_privbrowsing.html
> @@ +228,5 @@
> >  
> >  
> >  var pb = get_PBSvc();
> >  if (!pb) { // Private Browsing might not be available
> >    ok(true, "Private browsing service is not available");
> 
> Nit: while there, could you use "todo(false", in both test?

Implementing PB support in all of the Mozilla-based applications is not a todo item.  Think Thunderbird for example.  :-)

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to Ehsan Akhgari [:ehsan] from comment #3)
> > Nit: while there, could you use "todo(false", in both test?
> 
> Implementing PB support in all of the Mozilla-based applications is not a
> todo item.  Think Thunderbird for example.  :-)

Right. Though maybe special-case TB? (As we're special-casing SM sometimes.)

Comment 5

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b1714ea887c

Comment 6

[(no longer active)]

(In reply to Serge Gautherie (:sgautherie) from comment #4)
> (In reply to Ehsan Akhgari [:ehsan] from comment #3)
> > > Nit: while there, could you use "todo(false", in both test?
> > 
> > Implementing PB support in all of the Mozilla-based applications is not a
> > todo item.  Think Thunderbird for example.  :-)
> 
> Right. Though maybe special-case TB? (As we're special-casing SM sometimes.)

I don't think it's worth it, if you want, please file another bug.

Comment 7

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/mozilla-central/rev/8b1714ea887c

Comment 8

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showbuilds.cgi?tree=SeaMonkey&maxdate=1326867500&hours=24&legend=0&norules=1
2012/01/16 23:17:38 - 2012/01/18 01:16:10

V.Fixed