559493 - Suggest phone numbers for telephone inputs

Status: RESOLVED FIXED

(Mozilla Labs :: Identity, defect)

Description

[Ed Lee :Mardak]

Similar to how we detect html5 input type=email in bug 556817, we can detect type=tel and suggest phone numbers if we have any!

Comment 1

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/people/rev/b94acd27a414
Detect type=tel and guess for telephone-like fields and suggest phone numbers when searching for a person's name. 

This is a bit crude in that the suggestion shows up as Name <phone> with a value of "phone". Perhaps it should always show Name <email> and just have value be the phone...

Comment 2

[Ed Lee :Mardak]

Attachment: call ed ! ? ..

Comment 3

[Ed Lee :Mardak]

Oh, also, the search is only for the displayname and not for the telephone fields. So if you type a number... hopefully the person's name has a number!

Comment 4

[Mounir Lamouri (:mounir)]

I don't think you should use .getAttribute('type') but .type because .getAttribute('type') is not case-sensitive. Otherwise, you should set the string returned by .getAttribute('type') to lower case. .type is always a valid lower-case type.

Comment 5

[Ed Lee :Mardak]

For now, Firefox doesn't support type=<html5 stuff>, so node.type ends up reverting to "text". When Firefox supports these, we'll want to switch to the .type property.