525956 - White spaces at EOL in nsDisplaylist.cpp

Status: RESOLVED INVALID

(Core :: Layout, defect)

Description

[Mike Kristoffersen (:MikeK)]

Attachment: Patch with the whitespaces at EOL removed

/layout/base/nsDisplayList.cpp contains white spaces at EOL.

These white spaces are preventing me getting a larger patch reviewed.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We really don't need a separate bug report for each file.

Comment 2

[Mike Kristoffersen (:MikeK)]

(In reply to comment #1)
> We really don't need a separate bug report for each file.

Ok - that will make my life much more easy next time - I tried asking this to the reviewer of my main patch several times, but never got an answer, so had to make a choice...  I assume that you still want one patch per file?

Comment 3

[cajbir (:cajbir)]

If the larger patch you refer to is bug 422540 then these whitespace changes aren't preventing your larger patch from being reviewed. 

My request in that bug was just to not include whitespace changes in the patch containing the GStreamer changes to make it easier to review. 

Providing a GStreamer patch without the whitespace changes is not dependent on getting these other ones reviewed as far as I can see.

Comment 4

[Mike Kristoffersen (:MikeK)]

I'm closing this bug as its debated if it is an issue that should be dealt with, and if this is an acceptable way to deal with it.