504183 - Crash [@ nsHTMLInputElement::Focus] with file input focus and setting position:inherit, overflow:scroll

Status: RESOLVED FIXED

(Core :: XUL, defect, P2)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, which crashes current trunk build within 100ms. This regressed between 2009-06-10 and 2009-06-11, so probably a regression from bug 178324.

http://crash-stats.mozilla.com/report/index/6fdf09dc-8d4b-4a57-a27e-16f812090714?p=1
0  	xul.dll  	nsHTMLInputElement::Focus  	 content/html/content/src/nsHTMLInputElement.cpp:1365
1 	xul.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
2 	xul.dll 	XPCWrappedNative::CallMethod 	js/src/xpconnect/src/xpcwrappednative.cpp:2692

Comment 1

[Neil Deakin]

I can't reproduce this crash on any platform.

Comment 2

[Martijn Wargers (dead)]

I can reproduce this on MacOS X10.5 and Windows and also with a clean profile.

Comment 3

[Samuel Sidler (old account; do not CC)]

I can reproduce this as well on Mac OS X 10.5.

Comment 4

[Neil Deakin]

Attachment: another testcase

Comment 5

[Neil Deakin]

Attachment: add missing break

I can reproduce the patch with this second testcase. Turns out a break from the loop is just missing, as SetFocus can flush frames.

Comment 6

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/e1909f814b46

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Mass change: adding fixed1.9.2 keyword

(This bug was identified as a mozilla1.9.2 blocker which was fixed before the mozilla-1.9.2 repository was branched (August 13th, 2009) as per this query: http://is.gd/2ydcb - if this bug is not actually fixed on mozilla1.9.2, please remove the keyword. Apologies for the bugspam)