Closed Bug 501379 Opened 16 years ago Closed 16 years ago

Trunk build scrolling more area (scrolling faster) than it previously has

Categories

(Core :: Widget: Win32, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: u88484, Assigned: jimm)

References

Details

(Keywords: regression)

Attachments

(1 file)

Starting with today's trunk build (20090630), pages scroll further/faster than they did in the 20090629 build.
Product: Firefox → Core
QA Contact: general → general
Version: unspecified → Trunk
Bug 493037 looks like a good candidate for causing this.
Blocks: 493037
No longer blocks: 493037
Depends on: 493037
Another symptom: If mouse wheel scrolling is set to a page at a time, the browser page will move to the top or bottom of the page. I have to use the scroll bar to move to anywhere other than the top or bottom of the page if the page is more that two screen heights long.
This also appears on Windows 7.
Attached patch wheel fixSplinter Review
My refactor patch in 487245 split the wheel scroll event handling out into an event handler, which introduced a bug where aRetValue was not set correctly. This patch addresses that and also adds some commenting to OnWheelScroll to clearly explain what the handler does.
Assignee: nobody → jmathies
Depends on: 487245
No longer depends on: 493037
This also appears on Windows XP - Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090630 Minefield/3.6a1pre (.NET CLR 3.5.21022). This is extremely annoying. The middle-click-scroll speed is the same as it has always been, though.
Attachment #386052 - Flags: review+
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Verified Fixed using hourly build: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2a1pre) Gecko/20090630 Minefield/3.6a1pre Firefox/3.0.11 ID:20090630122827 changeset: http://hg.mozilla.org/mozilla-central/rev/0ebf4f99895e
Status: RESOLVED → VERIFIED
Component: General → Widget: Win32
QA Contact: general → win32
A unittest for this would be great. :)
(In reply to comment #9) > A unittest for this would be great. :) I was wondering the same thing, why didn't a unit test pick this up? Maybe it's hard to do as mouse drivers are involved in defining scroll speeds.
This still seems to be happening in 3.6 alpha 1. I'm running Windows 7.
(In reply to comment #11) > This still seems to be happening in 3.6 alpha 1. I'm running Windows 7. What you see is not this bug, but an intentional change in the scrolling behavior. See http://margaret.mit.edu/2009/08/making-firefox-feel-faster/ for more details (bug 462809).
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: