388529 - ReParentStyleContext doesn't process resulting style changes

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See discussion in bug 380012.  Unfortunately, we can't just process them here, as I point out in that bug.  We need a plan...

Perhaps we should actually try doing Hixie's proposal?  We could remove GetParent() on style contexts and have separate methods for getting parents of reset and inherit structs, and munge storage (with a bit?) so sometimes instead of a pointer we store a struct with two pointers.  Then we'll need a resolution method that takes two parent style contexts (with the current resolution method that just takes one inlining to it).  And rulenode changes.

This seems like it might be doable.

Comment 1

[Boris Zbarsky [:bzbarsky]]

The patch in bug 395623 will largely implement Hixie's proposal.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

In the process of migrating remaining bugs to the new severity system, the severity for this bug cannot be automatically determined. Please retriage this bug using the new severity system.

Comment 3

[Daniel Holbert [:dholbert]]

The ReParentStyleContext function doesn't exist anymore, and I suspect the associated style system code looks quite a bit different from how things looked when this bug was filed, via stylo and other changes over the last decade and a half.