386255 - Trunk XULRunner compile error in nsIEditingSession::MakeWindowEditable

Status: VERIFIED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

(I'm filing proxy for bent and weirdal on IRC; I don't actually build, FWIW.)

There's a compile error in trunk XULRunner (see https://bugzilla.mozilla.org/show_bug.cgi?id=237964#c78)

mozilla/embedding/browser/activex/src/control/MozillaBrowser.cpp(1295) : error
C2660: 'nsIEditingSession::MakeWindowEditable' : function does not take 4
arguments

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Bustage patch

I guessed PR_FALSE... is that ok?

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 270235 [details] [diff] [review]
Bustage patch

Lets get the bustage fix in, and get peters input on if this is the right fix later.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

mconnor wants this to wait until the tree is reopened

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: Bustage patch

Sorry about that. Should be true actually, the document needs to be completely editable.

Comment 5

[Peter Van der Beken [:peterv]]

This was checked in a while ago.

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

-> VERIFIED