376447 - Too-wide inline frames with nsTextFrameThebes

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD: MOZ_CO_DATE="Fri Mar 30 21:46:26 CDT 2007" with nsTextFrameThebes GetPresContext bustage fixed.

STEPS TO REPRODUCE:  Load URL in URL field

EXPECTED RESULTS: The green box should just wrap the "aaa"

ACTUAL RESULTS: The green box is a lot wider than that.

Comment 1

[Karl Tomlinson (:karlt)]

This looks good to me.  FIXED?

Comment 2

[Boris Zbarsky [:bzbarsky]]

I still see this, with MOZ_CO_DATE="Sat May 12 00:37:03 CDT 2007".

Might be pango-version-dependent, of course... dunno.  Might also have been fixed between then and when you commented.  Are there particular fixes that might have affected this in there?

Comment 3

[Karl Tomlinson (:karlt)]

Reproduced with MOZ_CO_DATE="Sat May 12 00:37:03 CDT 2007".
Fixed 17 minutes after this date, through bug 380210:

Working file: gfx/thebes/src/gfxPangoFonts.cpp
revision 1.77
date: 2007/05/12 05:54:31;  author: roc+%cs.cmu.edu;  state: Exp;  lines: +4 -4
Bug 380210. Fix appunits to Pango units conversions (only affects newtextframe).
 r=vlad

Comment 4

[Boris Zbarsky [:bzbarsky]]

Ah, yes.  That would exactly do it.  ;)

Thanks for catching it!