366084 - Numeric accesskeys still conflicting with tab switching

Status: VERIFIED FIXED

(Firefox :: Keyboard Navigation, defect)

Description

[Simon Bünzli]

Steps to reproduce:
1. Open a new tab and go there to http://plone.org/accessibility-info
2. Hit Alt+Shift+1

Expected result:
We should have navigated to http://plone.org/.

Actual result:
Additionally the first tab is activated.

Trivial fix following.

Note: On the trunk, this issue should get fixed in bug 351310 which AFAICT will change the tab switching modifier from Alt to Ctrl.

Comment 1

[Simon Bünzli]

Attachment: branch patch (don't switch tabs when Shift is pressed)

Note that Ctrl+Alt+<number> still works for tab selection...

(In reply to comment #0)
> Note: On the trunk, this issue should get fixed in bug 351310.

Obviously, I rather meant bug 345902. BTW: In light of such issues, I'd reconsider allowing Shift for tab selection at all (contrary to Mats' opinion in bug 345902 comment #2).

Comment 2

[Mats Palmgren (inactive)]

(In reply to comment #1)
> I'd reconsider allowing Shift for tab selection at all 

Yeah, that's probably safest after all.

Comment 3

[Mats Palmgren (inactive)]

Comment on attachment 250640 [details] [diff] [review]
branch patch (don't switch tabs when Shift is pressed)

Looks good, r=mats

Comment 4

[Nickolay_Ponomarev]

Is this meant to be checked in the 1.8 branch only or on trunk first?

Comment 5

[Simon Bünzli]

Comment on attachment 250640 [details] [diff] [review]
branch patch (don't switch tabs when Shift is pressed)

(In reply to comment #4)
This is mainly a branch patch, although I'd check it into Trunk as well (just in case bug 345902 doesn't make Firefox 3).

Comment 6

[Jay Patel [:jay]]

Please get an sr= from a UE person, preferably beltzner or mconnnor, to make sure this is the behavior we want on Linux.

Comment 7

[Simon Bünzli]

Comment on attachment 250640 [details] [diff] [review]
branch patch (don't switch tabs when Shift is pressed)

Mike: any objections to this change in particular (and/or removing the use of Shift in this place in general - see bug 345902 comment #6)?

Comment 8

[Jay Patel [:jay]]

beltzner:  We need a quick ui-review if this is going to make the upcoming release.  Please take a look.  Thanks!

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 250640 [details] [diff] [review]
branch patch (don't switch tabs when Shift is pressed)

Yeah, this looks OK to me.

Comment 10

[Jay Patel [:jay]]

Comment on attachment 250640 [details] [diff] [review]
branch patch (don't switch tabs when Shift is pressed)

Approved for 1.8 branch, a=jay for drivers.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/browser.js 	1.753

Comment 12

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/browser.js 	1.479.2.217

Comment 13

[Carsten Book [:Tomcat]]

Verified fixed for 1.8.1.2 - test build Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.2pre) Gecko/20070129 BonEcho/2.0.0.2pre ID:2007012904 - Fedora FC 6