326661 - Build fail with --disable-xul on windows

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Dorian]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; chrome://navigator/locale/navigator.properties; rv:1.8.0.1) Gecko/20060210 K-Meleon/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; chrome://navigator/locale/navigator.properties; rv:1.8.0.1) Gecko/20060210 K-Meleon/1.0

Build fail on windows when using --disable-xul because of a missing link:
GetTopLevelWindow()

It's obvious when looking at :
http://lxr.mozilla.org/mozilla1.8.0/source/widget/src/windows/nsWindow.cpp#8055

If you move #ifdef MOZ_XUL below it, then the build work, but it's not really a good idea. With the resulting build the mouse doesn't work well, mainly on scrollbar. GetTopLevelWindow() is only needed here:
http://lxr.mozilla.org/mozilla1.8.0/source/widget/src/windows/nsToolkit.cpp#947

So this is probably related.

Reproducible: Always

Comment 1

[Dorian]

Attachment: Patch1

Moved the #ifdef MOZ_XUL, so that the GetTopLevelWindow method if available for build with --disable-xul

Comment 2

[David G King]

Confirming.
This fails for me on a cygwin/Win32 build pulled today from Trunk.

Comment 3

[Murali Nandigama [:murali]]

You have a patch on this bug that is flagged for 'review?' and not assigned to any reviewer. If you want the patch to be reviewed please assign a reviewer. Thanks

Comment 4

[Dão Gottwald [:dao]]

This seems to have been fixed by bug 487245.

Comment 5

[Jim Mathies [:jimm]]

There is another bug identical to this out there somewhere that I think is resolved fixed, but I can't seem to find it.

Comment 6

[Jim Mathies [:jimm]]

(In reply to comment #5)
> There is another bug identical to this out there somewhere that I think is
> resolved fixed, but I can't seem to find it.

Doh! This is that bug! Never mind.