1957505 - Investigate the correctness in ContentContribution() after implementing the grid sizing algorithm step 3 and 4

Status: RESOLVED FIXED

(Core :: Layout: Grid, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

After implementing the grid sizing algorithm step 3 and 4, we should investigate if we need to update any logic that measures the grid item block size in ContentContribution() when the grid item establishes an orthogonal reflow.

    // We need to reflow the child to find its BSize contribution.
    // XXX this will give mostly correct results for now (until bug 1300366).
    ....

https://searchfox.org/mozilla-central/rev/7857ea04d142f2abc0d777085f9e54526c7cedf9/layout/generic/nsGridContainerFrame.cpp#5764-5765

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

we should investigate if we need to update any logic that measures the grid item block size in ContentContribution() when the grid item establishes an orthogonal reflow.

When investigating grid item cache in Bug 1956955, we'll consider orthogonal reflow.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1957505 - Remove obsolete comment mentioning Bug 1300366. r?#layout-grid-reviewers

We've closed Bug 1300366. If we ever discover any flaw in
ContentContribution(), we can file a new bug.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7b273e879a88
https://hg.mozilla.org/integration/autoland/rev/b98b1b2211fd
Remove obsolete comment mentioning Bug 1300366. r=dholbert DONTBUILD

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b98b1b2211fd