1935510 - Normative: Iterator helpers close receiver on argument validation failure

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Dan Minor [:dminor]]

Implement changes from https://github.com/tc39/ecma262/pull/3467

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1935510 - Part 1: Perform IteratorClose when callback argument is not a function. r=#spidermonkey-reviewers!

try-catch with an empty catch block, because exceptions from IteratorClose
have to be ignored.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1935510 - Part 2: Perform IteratorClose when limit coercion throws or limit is invalid. r=#spidermonkey-reviewers!

• Moved the ToNumber coercion into a separate try-catch block, so that it
  matches the spec more closely.
• Rethrowing the error through throw e doesn't propagate the original
  stacktrace when throwing non-Error values, see also bug 1843499 for a similar
  issue. This behaviour isn't great, but shouldn't block this bug. See also
  "builtin/Generator.js" for other self-hosted code which uses throw e to
  rethrow an exception.

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1935510 - Part 3: Update spec references. r=#spidermonkey-reviewers!

Update remaining spec references in Iterator.js.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a0b5db16379
Part 1: Perform IteratorClose when callback argument is not a function. r=spidermonkey-reviewers,iain
https://hg.mozilla.org/integration/autoland/rev/97665d31b0b6
Part 2: Perform IteratorClose when limit coercion throws or limit is invalid. r=spidermonkey-reviewers,iain
https://hg.mozilla.org/integration/autoland/rev/4fe79d50a0d8
Part 3: Update spec references. r=spidermonkey-reviewers,iain

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9a0b5db16379
https://hg.mozilla.org/mozilla-central/rev/97665d31b0b6
https://hg.mozilla.org/mozilla-central/rev/4fe79d50a0d8