1933140 - `using` keyword isn't displayed in console autocomplete

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

0. Build with the --enable-explicit-resource-management options enabled in mozconfig, and then turn on javascript.options.experimental.explicit_resource_management
1. In the console, type us

-> using should be in the list, but it's not

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

The list of keywords we display in the autocomplete is generated from https://searchfox.org/mozilla-release/rev/31c15d6d5d93f356ba1e880d406d88a13fdc9505/devtools/shared/webconsole/GenerateReservedWordsJS.py , which reads https://searchfox.org/mozilla-release/rev/31c15d6d5d93f356ba1e880d406d88a13fdc9505/js/src/frontend/ReservedWords.h
using is conditionnaly added in here, and our script don't handle this: https://searchfox.org/mozilla-release/rev/31c15d6d5d93f356ba1e880d406d88a13fdc9505/js/src/frontend/ReservedWords.h#41

IF_EXPLICIT_RESOURCE_MANAGEMENT(MACRO(using, using_, TokenKind::Using)) \

not sure we should do more here, this will probably be fixed when explicit resource management is enabled by default

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1933140 - [devtools] Add shared module for GenerateReservedWordsJS.py and GenerateReservedWords.py to read reserved words list. r=arai.

This is taking inspiration from GenerateReservedWords.py.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1933140 - [devtools] Make sure using keyword is in autocompletion result when expected. r=#devtools

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/172e8b8336e7
https://hg.mozilla.org/integration/autoland/rev/7f5678abbcac
[devtools] Add shared module for GenerateReservedWordsJS.py and GenerateReservedWords.py to read reserved words list. r=arai.
https://github.com/mozilla-firefox/firefox/commit/4339627f908e
https://hg.mozilla.org/integration/autoland/rev/285b6f64fd56
[devtools] Make sure using keyword is in autocompletion result when expected. r=devtools-reviewers,ochameau

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/7f5678abbcac
https://hg.mozilla.org/mozilla-central/rev/285b6f64fd56