Closed
Bug 1914907
Opened 1 year ago
Closed 1 year ago
[css-color] Allow CalcNode to be stored in a color component
Categories
(Core :: CSS Parsing and Computation, task)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
133 Branch
| Tracking | Status | |
|---|---|---|
| firefox133 | --- | fixed |
People
(Reporter: tlouw, Assigned: tlouw)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
No description provided.
| Assignee | ||
Comment 1•1 year ago
|
||
This is part of the changes to not do any resolving when parsing
specified colors. Specified colors should preserve as much data as
possible for round tripping. This means we have to move resolving to the
to_computed_value stage and after.
| Assignee | ||
Comment 2•1 year ago
|
||
More ergonomic to work with and not so verbose.
Updated•1 year ago
|
Attachment #9420785 -
Attachment description: WIP: Bug 1914907 - Store CalcNode inside a color component. r=#layout → Bug 1914907 - Store CalcNode inside a color component. r=#layout
Updated•1 year ago
|
Attachment #9421016 -
Attachment description: WIP: Bug 1914907 - Rustify NumberOr* enums r=#layout → Bug 1914907 - Rustify NumberOr* enums r=#layout
Comment 3•1 year ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:tlouw, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.
Flags: needinfo?(tlouw)
Flags: needinfo?(emilio)
Updated•1 year ago
|
Attachment #9420785 -
Attachment description: Bug 1914907 - Store CalcNode inside a color component. r=#layout → WIP: Bug 1914907 - Store CalcNode inside a color component. r=#layout
Updated•1 year ago
|
Attachment #9421016 -
Attachment description: Bug 1914907 - Rustify NumberOr* enums r=#layout → WIP: Bug 1914907 - Rustify NumberOr* enums r=#layout
Updated•1 year ago
|
Attachment #9420785 -
Attachment description: WIP: Bug 1914907 - Store CalcNode inside a color component. r=#layout → Bug 1914907 - Store CalcNode inside a color component. r=#layout
Updated•1 year ago
|
Attachment #9421016 -
Attachment description: WIP: Bug 1914907 - Rustify NumberOr* enums r=#layout → Bug 1914907 - Rustify NumberOr* enums r=#layout
Pushed by tlouw@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/52805769af10
Store CalcNode inside a color component. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/0e64171432f6
Rustify NumberOr* enums r=layout-reviewers,emilio
Comment 7•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/52805769af10
https://hg.mozilla.org/mozilla-central/rev/0e64171432f6
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox133:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•