Closed Bug 1914907 Opened 1 year ago Closed 1 year ago

[css-color] Allow CalcNode to be stored in a color component

Categories

(Core :: CSS Parsing and Computation, task)

task

Tracking

()

RESOLVED FIXED
133 Branch
Tracking Status
firefox133 --- fixed

People

(Reporter: tlouw, Assigned: tlouw)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.

This is part of the changes to not do any resolving when parsing
specified colors. Specified colors should preserve as much data as
possible for round tripping. This means we have to move resolving to the
to_computed_value stage and after.

More ergonomic to work with and not so verbose.

Attachment #9420785 - Attachment description: WIP: Bug 1914907 - Store CalcNode inside a color component. r=#layout → Bug 1914907 - Store CalcNode inside a color component. r=#layout
Attachment #9421016 - Attachment description: WIP: Bug 1914907 - Rustify NumberOr* enums r=#layout → Bug 1914907 - Rustify NumberOr* enums r=#layout

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:tlouw, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(tlouw)
Flags: needinfo?(emilio)

Tiaan is working on this iirc.

Flags: needinfo?(emilio)
Attachment #9420785 - Attachment description: Bug 1914907 - Store CalcNode inside a color component. r=#layout → WIP: Bug 1914907 - Store CalcNode inside a color component. r=#layout
Attachment #9421016 - Attachment description: Bug 1914907 - Rustify NumberOr* enums r=#layout → WIP: Bug 1914907 - Rustify NumberOr* enums r=#layout

Still wip

Flags: needinfo?(tlouw)
Attachment #9420785 - Attachment description: WIP: Bug 1914907 - Store CalcNode inside a color component. r=#layout → Bug 1914907 - Store CalcNode inside a color component. r=#layout
Attachment #9421016 - Attachment description: WIP: Bug 1914907 - Rustify NumberOr* enums r=#layout → Bug 1914907 - Rustify NumberOr* enums r=#layout
Pushed by tlouw@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/52805769af10 Store CalcNode inside a color component. r=layout-reviewers,emilio https://hg.mozilla.org/integration/autoland/rev/0e64171432f6 Rustify NumberOr* enums r=layout-reviewers,emilio
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
Blocks: 1893966
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: