1910646 - New wpt crashes in /css/css-variables/variable-css-wide-keywords.html

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 46814 found new crashes in CI

Affected Tests

• /css/css-variables/variable-css-wide-keywords.html [wpt.fyi]: CRASH [Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug], OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub]

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

Getting the crash signature into these bug reports is a TODO; sorry

These updates will be on mozilla-central once bug 1903353 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[David Shin[:dshin]]

Crash is on debug assertion.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1877383

:zrhoffman, since you are the author of the regressor, bug 1877383, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Zach Hoffman [:zrhoffman]]

Attachment: Bug 1910646 - Do not assert that variables are computed before substituting references. r=#style

If the value of a custom property is a CSS-wide keyword in fallback, it
will not already be computed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd4763f0b770
Do not assert that variables are computed before substituting references. r=firefox-style-system-reviewers,emilio

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/dd4763f0b770

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:zrhoffman, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox137 to wontfix.

For more information, please visit BugBot documentation.