1905239 - Dynamic Code Brand Checks

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Alexandre Folle de Menezes]

The proposal is currently in Stage 3.

Comment 1

[Frédéric Wang (:fredw)]

These are the spec changes:

• https://tc39.es/ecma262/#sec-hostensurecancompilestrings is edited as described in https://tc39.es/proposal-dynamic-code-brand-checks/#sec-hostensurecancompilestrings
• https://tc39.es/ecma262/#sec-performeval is edited as described in https://tc39.es/proposal-dynamic-code-brand-checks/#sec-performeval
  • This change relies on HostGetCodeForEval hook, introduced in https://tc39.es/ecma262/#sec-host-hooks-summary: https://tc39.es/proposal-dynamic-code-brand-checks/#sec-hostgetcodeforeval
• https://tc39.es/ecma262/#sec-createdynamicfunction is edited as described in https://tc39.es/proposal-dynamic-code-brand-checks/#sec-createdynamicfunction

IIUC our implementation of HostEnsureCanCompileStrings is essentially JSContext::isRuntimeCodeGenEnabled:

https://searchfox.org/mozilla-central/rev/b477cd37e845005dac8881427fa06a2771d993db/js/src/vm/JSContext.cpp#1237
https://searchfox.org/mozilla-central/search?q=symbol:_ZN9JSContext23isRuntimeCodeGenEnabledEN2JS11RuntimeCodeENS0_6HandleIP8JSStringEE&redirect=false

Comment 2

[Frédéric Wang (:fredw)]

Attachment: Bug 1905239 - Introduce HostGetCodeForEval hook for PerformEval. r=#spidermonkey-reviewers,dminor

See https://tc39.es/proposal-dynamic-code-brand-checks

Comment 3

[Frédéric Wang (:fredw)]

Attachment: Bug 1905239 - Add new parameters to HostEnsureCanCompileStrings hook. r=#spidermonkey-reviewers,dminor

See https://tc39.es/proposal-dynamic-code-brand-checks

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f27e56ebfc0b
Introduce HostGetCodeForEval hook for PerformEval. r=tschuster
https://hg.mozilla.org/integration/autoland/rev/a282ae3a55f7
Add new parameters to HostEnsureCanCompileStrings hook. r=tschuster
https://hg.mozilla.org/integration/autoland/rev/029305d7a99b
apply code formatting via Lando

Comment 5

[amarc]

Backed out for causing build bustages @ FrontendContext.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line:

Assertion failure: !maybeCx_->isExceptionPending(), at /builds/worker/checkouts/gecko/js/src/frontend/FrontendContext.cpp:99

Comment 6

[Frédéric Wang (:fredw)]

(In reply to amarc from comment #5)

Backed out for causing build bustages @ FrontendContext.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line:

Assertion failure: !maybeCx_->isExceptionPending(), at /builds/worker/checkouts/gecko/js/src/frontend/FrontendContext.cpp:99

The new test must clear any previous EvalError exception before running a new failing eval / new Function called. Fixed in the latest uploaded patches.

TIL: the try fuzzy tasks for jsapi-tests are spidermonkey builds...

Comment 7

[Frédéric Wang (:fredw)]

https://treeherder.mozilla.org/jobs?repo=try&revision=75cbd18d7a9be1e74d2a61501b47a33d040a7f8c

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b575160525c1
Introduce HostGetCodeForEval hook for PerformEval. r=tschuster
https://hg.mozilla.org/integration/autoland/rev/2baefcde5dbc
Add new parameters to HostEnsureCanCompileStrings hook. r=tschuster
https://hg.mozilla.org/integration/autoland/rev/dbad1906f96c
apply code formatting via Lando

Comment 9

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/b575160525c1
https://hg.mozilla.org/mozilla-central/rev/2baefcde5dbc
https://hg.mozilla.org/mozilla-central/rev/dbad1906f96c