1887687 - reject-multiple-getters-calls should allow multiple calls when 3rd argument is used and `global` is different

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Alexandre Poirot [:ochameau]]

See https://phabricator.services.mozilla.com/D203409?id=839207#inline-1137461
I had to disable the rule on the following legit usages of duplicated calls to defineESModuleGetters:

const lazy = {};
ChromeUtils.defineESModuleGetters(
  lazy,
  {
    isWindowGlobalPartOfContext:
      "resource://devtools/server/actors/watcher/browsing-context-helpers.sys.mjs",
    WindowGlobalLogger:
      "resource://devtools/server/connectors/js-window-actor/WindowGlobalLogger.sys.mjs",
  },
  { global: "contextual" }
);

// TargetActorRegistery has to be shared between all devtools instances
// and so is loaded into the shared global.
// eslint-disable-next-line mozilla/reject-multiple-getters-calls
ChromeUtils.defineESModuleGetters(
  lazy,
  {
    TargetActorRegistry:
      "resource://devtools/server/actors/targets/target-actor-registry.sys.mjs",
  },
  { global: "shared" }
);

Comment 1

[Mark Banner (:standard8)]

Actually, going to add this to the post esm-ification work.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1887687 - Reflect global option to reject-multiple-getters-calls rule. r?Standard8!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9b265a1368e
Reflect global option to reject-multiple-getters-calls rule. r=Standard8,frontend-codestyle-reviewers,Gijs

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a9b265a1368e