1884424 - [css-shapes-1] Implement shape() function for offset-path

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1884424 - Support shape() for offset-path and render it.

We treat it as other basic shapes (excluding path(), which has some
special handling and it doesn't rely on the current layout position).

Therefore, we don't have any implementation for caching and we would like to
leave this part to Bug 1837042.

Also, add some more simple tests in css/motion to make sure we render it
properly.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/232a3ceaa406
Support shape() for offset-path and render it. r=layout-reviewers,emilio

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/45389 for changes under testing/web-platform/tests

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/232a3ceaa406

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 6

[Donal Meehan [:dmeehan - PTO - Back Oct 13]]

:boris could you consider nominating this for a release note? (Process info)
We could include it in the nightly release notes.

Comment 7

[Boris Chiou [:boris]]

Release Note Request (optional, but appreciated)
[Why is this notable]: This is a new feature on Firefox. We support shape() function on offset-path property now. It provides a better CSS syntax for path commands (compared with path(), which uses SVG Path string syntax).
[Affects Firefox for Android]: Yes
[Suggested wording]: Support shape() function on offset-path property.
[Links (documentation, blog post, etc)]:
https://drafts.csswg.org/css-shapes-2/#shape-function
https://drafts.fxtf.org/motion-1/#offset-path-property

Comment 8

[Donal Meehan [:dmeehan - PTO - Back Oct 13]]

Thanks, added to the Fx126 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx126 release notes.

Comment 9

[Dipika]

Hi Boris, could you confirm if the support for the shape() function in offset-path and in clip-path will be available only in Nightly starting from release 126 (behind the layout.css.basic-shape-shape.enabled preference)?

Comment 10

[Boris Chiou [:boris]]

(In reply to Dipika from comment #9)

Hi Boris, could you confirm if the support for the shape() function in offset-path and in clip-path will be available only in Nightly starting from release 126 (behind the layout.css.basic-shape-shape.enabled preference)?

Yes. Since Fx126, and until now, we support shape function only on Nightly, behind layout.css.basic-shape-shape.enabled.

Comment 11

[Dipika]

MDN docs have been updated and the shape() function documentation is now available. The related work can be tracked via the doc issue https://github.com/mdn/content/issues/33081.
Thanks a lot Boris for your timely help with all my questions!

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Removing from the Nightly release notes as this has been included for more than 3 cycles now.

Comment 13

[Daniel Holbert [:dholbert]]

--> updating title and metabug to point at css-shapes-1 rather than 2, since this moved from css-shapes-2 to css-shapes-1 (per csswg discussion). (The spec text is now here: https://drafts.csswg.org/css-shapes-1/#shape-function)