1881564 - Support ChromeUtils.importESModule(..., {global: "current"}) in service worker

Status: RESOLVED FIXED

(Core :: XPConnect, task, P3)

Description

[Tooru Fujisawa [:arai]]

Currently ServiceWorker doesn't have module loader, which results in ChromeUtils.importESModule(..., {global: "current"}) not available there for DevTools debugger code (bug 1789981)

https://searchfox.org/mozilla-central/rev/a8cc31504a2379bcf8ba395d2da7bb632b5521d6/dom/workers/ScriptLoader.cpp#519-522

// Set up the module loader, if it has not been initialzied yet.
if (!aWorkerPrivate->IsServiceWorker()) {
  self->InitModuleLoader();
}

The reason for not initializing is bug 1694377 and https://github.com/whatwg/html/pull/6395 where dynamic import should be prevented for ServiceWorker.
Then, there's also bug 1360870 which is to support modules in service worker.

So, initializing module loader itself is fine, as long as dynamic import is kept unavailable.
We could add some hook or flag to prevent dynamic import, and then just initialize module loader (maybe lazily), so that ChromeUtils.importESModule(..., {global: "current"}) can access it.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1881564 - Initialize module loader also for ServiceWorker to allow ChromeUtils.importESModule in DevTools ServiceWorker debugger global. r?yulia!

Dynamic import is still disabled for service worker by WorkerModuleLoader::CreateDynamicImport.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f07a1c73ff7
Initialize module loader also for ServiceWorker to allow ChromeUtils.importESModule in DevTools ServiceWorker debugger global. r=yulia

Comment 3

[Cristian Tuns]

Backed out for causing wpt failures in serviceworker.any.serviceworker.html

• Backout link
• Push with failures
• Failure Log
• Failure line: PROCESS-CRASH | application crashed [@ RefPtr<mozilla::dom::StrongWorkerRef>::get] | /html/semantics/scripting-1/the-script-element/module/dynamic-import/microtasks/serviceworker.any.serviceworker.html

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/012dcfeb8452
Initialize module loader also for ServiceWorker to allow ChromeUtils.importESModule in DevTools ServiceWorker debugger global. r=yulia

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/012dcfeb8452