1878169 - dependentlibs.list Is missing files on macOS

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Haik Aftandilian [:haik]]

On macOS, dependentlibs.list is missing some files. :nalexander noticed this and per :glandium, this is a regression from bug 1770484.

With Firefox 122.0,

$ cat /Applications/Firefox.app/Contents/Resources/dependentlibs.list 
XUL

On macOS, we don't depend on dependentlibs.list, but having XUL dependency libs in the list would make the OS preload them.

:glandium explained "dependentlibs.list is used to load the libraries that libxul depends on and that ld.so wouldn't find on its own because we don't set a rpath on ELF-targets. Of course, on mac and windows, it's not strictly necessary, but it also makes the OS preload the files too."

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1770484

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to Haik Aftandilian [:haik] from comment #0)

On macOS, dependentlibs.list is missing some files. :nalexander noticed this and per :glandium, this is a regression from bug 1770484.

With Firefox 122.0,

$ cat /Applications/Firefox.app/Contents/Resources/dependentlibs.list 
XUL

On macOS, we don't depend on dependentlibs.list, but having XUL dependency libs in the list would make the OS preload them.

It appears that some of the update tests do depend on dependentlibs.list, and that is potentially interacting with Bug 1707753. We determine what .dylib files to copy using that list, see https://searchfox.org/mozilla-central/rev/14dc8f0e748d44778a02ffcf9ebcda3851b2bf9e/toolkit/mozapps/update/tests/data/xpcshellUtilsAUS.js#2524-2541.

I'm not 100% sure this is relevant but it's certainly impacting running tests locally -- the update tests don't produce a .app directory that can launch Firefox since libmozglue.dylib isn't in the correct place. With a complete dependentlibs.list, all the libraries would be in the correct place.

Comment 3

[Haik Aftandilian [:haik]]

Attachment: Bug 1878169 - dependentlibs.list Is missing files on macOS r?glandium

Update dependentlibs.py to account for the earlier change in bug 1770484 that replaced use of @executable_path with @rpath.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db2c49929a4f
dependentlibs.list Is missing files on macOS r=glandium

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/db2c49929a4f