1875638 - Add ImportESModuleOptionsDictionary parameter to ChromeUtils.defineESModuleGetters

Status: RESOLVED FIXED

(Core :: XPConnect, task)

Description

[Tooru Fujisawa [:arai]]

ImportESModuleOptionsDictionary option is used for controlling where the module is loaded into.
Currently it has loadInDevToolsLoader field to control whether to load into DevTools' global or not.

Bug 1803810 is going to add more options, including "load into current global" behavior, that is module-variant of Services.scriptloader.loadSubScript.
and it's better having the option also in ChromeUtils.defineESModuleGetters, so that people don't have to use ChromeUtils.defineLazyGetter+ChromeUtils.importESModule

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1875638 - Part 1: Add ImportESModuleOptionsDictionary parameter to ChromeUtils.defineESModuleGetters. r?jonco!

Pass the global/loadInDevToolsLoader options to the lazy getter, with encoding
the option into single integer and store into the getter function's extended
slot.

Depends on D199462

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1875638 - Part 2: Make ChromeUtils.defineESModuleGetters available in workers. r?jonco!

Expose defineESModuleGetters to worker as well, while only supporting
{ global: "current" } option.

Depends on D199463

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1875638 - Part 3: Add tests. r?jonco!

Depends on D199464

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32b63d4ef3d2
Part 1: Add ImportESModuleOptionsDictionary parameter to ChromeUtils.defineESModuleGetters. r=jonco
https://hg.mozilla.org/integration/autoland/rev/9e528ea23760
Part 2: Make ChromeUtils.defineESModuleGetters available in workers. r=jonco
https://hg.mozilla.org/integration/autoland/rev/ea95dfbc56f0
Part 3: Add tests. r=jonco

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for workers/clients related dt failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: EST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-log-points-workers.js | Test timed out -

Comment 6

[Tooru Fujisawa [:arai]]

Apparently this depends on bug 1875639 part 2 changes, due to pre-existing use of ChromeUtils.defineESModuleGetters in devtools worker, without actually loading modules.
the validation for global parameter happens at call, and it fails.
I'll fix it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d00ab2fcde7
Part 1: Add ImportESModuleOptionsDictionary parameter to ChromeUtils.defineESModuleGetters. r=jonco
https://hg.mozilla.org/integration/autoland/rev/dbb3a63499dd
Part 2: Make ChromeUtils.defineESModuleGetters available in workers. r=jonco
https://hg.mozilla.org/integration/autoland/rev/f75a84b9f7d5
Part 3: Add tests. r=jonco

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6d00ab2fcde7
https://hg.mozilla.org/mozilla-central/rev/dbb3a63499dd
https://hg.mozilla.org/mozilla-central/rev/f75a84b9f7d5