1850053 - WPT css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-* failures in Firefox

Status: NEW

(Core :: Layout: Grid, defect)

Description

[Daniel Holbert [:dholbert]]

We fail this WPT:
https://wpt.fyi/results/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-011.html
http://wpt.live/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-011.html

I think this a version of bug 1310551.

Essentially it seems that we size the firstRowFirstColumn element to be ~1em wide, when in fact it should be ~3em wide. If I use devtools to add width:3em to that element, then it looks visually like the test passes (modulo red fringes which I think don't show up in the test harness where antialiasing is disabled for the Ahem font). So that's the size that we're failing to apply automatically (to shrinkwrap our content).

(To analyze/visualize the behavior-difference vs. other browsers here, it's easiest to remove the green background from the block element, and then add a border around firstRowFirstColumn.)

Comment 1

[Daniel Holbert [:dholbert]]

Actually, we fail a handful of tests with this same prefix:
https://wpt.fyi/results/css/css-grid/alignment/self-baseline?q=grid-self-baseline-changes-grid-area-size

Specifically these ones:
https://wpt.fyi/results/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-003.html
https://wpt.fyi/results/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-006.html
https://wpt.fyi/results/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-007.html
https://wpt.fyi/results/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-008.html
https://wpt.fyi/results/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-009.html
https://wpt.fyi/results/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-010.html
https://wpt.fyi/results/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-011.html (the one linked in comment 0)
https://wpt.fyi/results/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-012.html

I haven't looked through all of them in detail, but the tests look similar, and I'm guessing they're largely failing for a shared reason or small set of reasons.

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #1)

Actually, we fail a handful of tests with this same prefix:
[...]
Specifically these ones:
https://wpt.fyi/results/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-003.html
https://wpt.fyi/results/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-006.html

We pass these two^ now, FWIW (as of bug 1609403 - here's where we removed our failure annotation:
https://hg-edge.mozilla.org/mozilla-central/rev/99e226ce1286#l12.1

But we still fail the others quoted in comment 1 (-007 through -012).

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #2)

But we still fail the others quoted in comment 1 (-007 through -012).

+CC TYLin who has an in-progress patch that might help in some of these tests (per https://treeherder.mozilla.org/jobs?repo=try&revision=83b33d985b3e5e755b609b475b9dcf4fd5d9189b&selectedTaskRun=cHkk5sXUTPSWcTTErXgOsw.0 , https://treeherder.mozilla.org/logviewer?job_id=518770938&repo=try )