Import AddonManager.sys.mjs instead of AddonManager.jsm in devtools/
Categories
(WebExtensions :: General, task)
Tracking
(Not tracked)
People
(Reporter: robwu, Unassigned)
References
Details
In bug 1836482, I migrated AddonsManager from JSM to ESM, and replaced the imports of AddonManager.jsm with ESM imports of AddonManager.sys.mjs
For some unknown reason, the devtools framework loads an independent instance of AddonManager.sys.mjs instead of the actual (already-loaded) instance of the AddonManager, which breaks the ability to load extensions via the remote devtools server.
I've reverted the sys.mjs imports back to jsm for devtools/ in bug 1837185 until the cause of this problem is known. Once this has been fixed, we should be able to revert the work-around from bug 1837185.
|
||
Comment 1•2 years ago
|
||
This is interesting. I think there's some special module handling going in devtools, maybe due to how their module loading works. Adding :ochameau who might be able to guide.
|
Reporter | |
Comment 2•2 years ago
|
||
I've fixed the underlying issue in the original bug instead of in this follow-up, details in https://phabricator.services.mozilla.com/D180243#5950782
|
|
Reporter | |
Comment 3•2 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #1)
This is interesting. I think there's some special module handling going in devtools, maybe due to how their module loading works. Adding :ochameau who might be able to guide.
FYI I reported bug 1837394 for that.
Description
•