1831252 - [wpt-sync] Sync PR 39839 - Revert "Fix painting order of text-shadow on (underline) decorations"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39839 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39839
Details from upstream follow.

Maggie Cai <[e-mail]> wrote:

Revert "Fix painting order of text-shadow on (underline) decorations"

This reverts commit 4678fac54a6cbf8038e3128d889d47dd5317e941.

Reason for revert: This CL is likely the cause for the failed test external/wpt/css/css-text-decor/text-shadow/standards-decor-noblur-2.html on builder mac11-arm64-rel-tests, starting from https://ci.chromium.org/p/chromium/builders/ci/mac11-arm64-rel-tests/18057. It seems also cause similar failure on other builders: https://luci-analysis.appspot.com/p/chromium/clusters/testname-v4/e94be6eaafebcb5ce1cfd888d77b64d3#recent-failures

Original change's description:

Fix painting order of text-shadow on (underline) decorations

The right-most shadow should be at the bottom, so needs to be painted
first (c.f. TextPainterBase::CreateDrawLooper()).

Iterate the text-shadow vector in reverse in
NGTextPainterBase::PaintUnderOrOverLineDecorationShadows().

Fixed: 1442188
Change-Id: I02e0b9909d8280b3e893ca0c58225ae5dca94ace
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4499286
Auto-Submit: Fredrik Söderquist \<[e-mail]>
Reviewed-by: Stephen Chenney \<[e-mail]>
Commit-Queue: Stephen Chenney \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1139099}

Change-Id: Ic1648b6bceba0d30e17f4d8bcb2f82589ca4c7c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4505734
Commit-Queue: Maggie Cai \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Owners-Override: Maggie Cai \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1139361}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 39839 applied with additional changes from upstream: 0cf7c77f9996ae00108bd033d322205c33a9e9d6

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=15ac7383a7054ab98dfb708a580fcdfe6409cbd7

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Try push failed: decision task EzFcHs5iR16wSAknZJ05IA returned error

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=815de07a750a5fcb367982280df5527187ce3ae7

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/395f86e1880b
[wpt PR 39839] - Revert "Fix painting order of text-shadow on (underline) decorations", a=testonly

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/395f86e1880b