1830575 - [wpt-sync] Sync PR 39752 - [no-vary-search-hint] Add WPT test for No-Vary-Search hint functionality

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39752 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39752
Details from upstream follow.

Liviu Tinta <[e-mail]> wrote:

[no-vary-search-hint] Add WPT test for No-Vary-Search hint functionality

In order to add a WPT test we have to create a situation where the
navigation to a potentially matching URL happens before the browser
receives the headers, but after the browser makes the prefetch request.

In order to synchronize the navigation we are introducing a new
python handler which will synchronize the in flight prefetch with the
WPT test by using request.server.stash.

Flow:

• prefetch prefetch_nvs_hint.py?uuid=...&nvs_header=...&otherqueryparams
• the prefetch request above includes no_vary_search_hint in the speculation
  rules
• the server blocks progress on this prefetch request on the server side so
  from the browser perspective the server is "thinking"
• the test starts navigation to
  prefetch_nvs_hint.py?uuid=...&nvs_header=...&otherdifferentqueryparams.
  This navigation matches by No-Vary-Search hint the above in
  progress prefetch.
• the test fetches prefetch_nvs_hint.py?uuid=...&unblock="unblock"
  which unblocks the in progress prefetch so that the in-progress
  navigation can continue

Bug: 1416659
Change-Id: I1b33b2bb8c649744f59ff6fda9f45cabeaa88847
Reviewed-on: https://chromium-review.googlesource.com/4490867
WPT-Export-Revision: 3860f28138e4e83017eee03ed7ed367301536077

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0854cc94e8b8255d3d4ebe6884cede487fa2f0d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad519149c2adb2089121441352013ebc14e0186a

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Chrome, and Safari on GitHub CI

Total 25 tests and 1 subtests

Status Summary

Firefox

OK : 25
FAIL: 25

Chrome

OK : 25
PASS: 7
FAIL: 18

Safari

OK : 25
FAIL: 25

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?13-13 [wpt.fyi]
  • Use in-flight prefetch as even though all query parameters except c and d can be ignored, c value matches and d value matches. Some query parameters to be ignored appear multiple times in the query.: FAIL (Chrome: FAIL, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?22-22 [wpt.fyi]
  • Use the in-flight prefetch. Non-ASCII key - 2 UTF-8 code units. Don't vary the response on the non-ASCII key.: FAIL (Chrome: FAIL, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?2-2 [wpt.fyi]
  • Don't use in-flight prefetch as there is no No-Vary-Search hint.: FAIL (Chrome: PASS, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?17-17 [wpt.fyi]
  • Use in-flight prefetch as the URLs do not vary on any query parameters. Allow extension via parameters.: FAIL (Chrome: FAIL, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?4-4 [wpt.fyi]
  • Use in-flight prefetch as the URLs do not vary by a and b.: FAIL (Chrome: FAIL, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?8-8 [wpt.fyi]
  • Don't use in-flight prefetch as key-order is set to false and the URLs are not identical.: FAIL (Chrome: PASS, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?18-18 [wpt.fyi]
  • Use in-flight prefetch as all query parameters except c can be ignored. Allow extension via parameters.: FAIL (Chrome: FAIL, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?9-9 [wpt.fyi]
  • Use in-flight prefetch as all query parameters except c can be ignored.: FAIL (Chrome: FAIL, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?14-14 [wpt.fyi]
  • Use in-flight prefetch as all query parameters except c can be ignored. Allow extension via parameters.: FAIL (Chrome: FAIL, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?19-19 [wpt.fyi]
  • Don't use the in-flight prefetched URL. Empty No-Vary-Search means default URL variance. The prefetched and the navigated URLs have to be the same.: FAIL (Chrome: PASS, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?7-7 [wpt.fyi]
  • Use in-flight prefetch as the URLs have the same values for all keys, only differing by order and using ?1 for specifying a true value.: FAIL (Chrome: FAIL, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?23-23 [wpt.fyi]
  • Use the in-flight prefetch. Non-ASCII key - 2 UTF-8 code units. Don't vary the response on the non-ASCII key.: FAIL (Chrome: FAIL, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?24-24 [wpt.fyi]
  • Don't use the in-flight prefetch. Non-ASCII key - 2 UTF-8 code units. Vary the response on the non-ASCII key.: FAIL (Chrome: PASS, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?10-10 [wpt.fyi]
  • Use in-flight prefetch as all query parameters except c can be ignored. Only the last except matters.: FAIL (Chrome: FAIL, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?1-1 [wpt.fyi]
  • Use in-flight prefetch as query parameter b has the same value.: FAIL (Chrome: FAIL, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?6-6 [wpt.fyi]
  • Use in-flight prefetch as the URLs have the same values for all keys, only differing by order.: FAIL (Chrome: FAIL, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?21-21 [wpt.fyi]
  • Use the in-flight prefetch. Empty No-Vary-Search means default URL variance. The prefetched and the navigated URLs have to be the same.: FAIL (Chrome: FAIL, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?5-5 [wpt.fyi]
  • Do not use in-flight prefetch as the navigation URL has a different value for the "b" query parameter.: FAIL (Chrome: PASS, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?12-12 [wpt.fyi]
  • Use in-flight prefetch as even though all query parameters except c and d can be ignored, c value matches and d value matches.: FAIL (Chrome: FAIL, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?25-last [wpt.fyi]
  • Use the in-flight prefetch. Non-ASCII key - 2 UTF-8 code units. Vary the response on the non-ASCII key.: FAIL (Chrome: FAIL, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?16-16 [wpt.fyi]
  • Use in-flight prefetch as the URLs have the values in different order for a. Allow extension via parameters.: FAIL (Chrome: FAIL, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?11-11 [wpt.fyi]
  • Don't use in-flight prefetch as even though all query parameters except c can be ignored, c has different value.: FAIL (Chrome: PASS, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?15-15 [wpt.fyi]
  • Use in-flight prefetch as query parameter c can be ignored. Allow extension via parameters.: FAIL (Chrome: FAIL, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?20-20 [wpt.fyi]
  • Use the in-flight prefetch. Empty No-Vary-Search means default URL variance. The prefetched and the navigated URLs have to be the same.: FAIL (Chrome: FAIL, Safari: FAIL)
• /speculation-rules/prefetch/no-vary-search/prefetch-single-with-hint.https.html?3-3 [wpt.fyi]
  • Don't use in-flight prefetch as the prefetched URL has the extra "a" query parameter.: FAIL (Chrome: PASS, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e00d8f3becd8
[wpt PR 39752] - [no-vary-search-hint] Add WPT test for No-Vary-Search hint functionality, a=testonly
https://hg.mozilla.org/integration/autoland/rev/3e2fb1385e73
[wpt PR 39752] - Update wpt metadata, a=testonly

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e00d8f3becd8
https://hg.mozilla.org/mozilla-central/rev/3e2fb1385e73