Closed Bug 1830565 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 39750 - [GridNG] Handle opposite writing direction subgrids

Categories

(Core :: Layout: Grid, task, P4)

task

Tracking

()

RESOLVED FIXED
115 Branch
Tracking Status
firefox115 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39750 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39750
Details from upstream follow.

Kurt Catti-Schmidt <kschmi@microsoft.com> wrote:

[GridNG] Handle opposite writing direction subgrids

We were not previously accounting for opposite direction writing modes
in subgrids. This change reverses the order of set/range lookup and grid
geometry, and adjusts margin-border-padding in grid geometry to account
for opposing directions.

There will be followup work necessary for mapping orthogonal subgrids
while also accounting for writing direction. For now, there's a
condition blocking this from going down the new path as it caused a
regression.

A new test was added specifically for this behavior, as existing
tests only checked for this indirectly.

Bug: 618969
Change-Id: I3c3c8e99268beb5cfee81cb36ff810ec6c496cdb

Reviewed-on: https://chromium-review.googlesource.com/4484336
WPT-Export-Revision: 692c4b6c036a67d3d9ae18e50842cb983e42a882

Component: web-platform-tests → Layout: Grid
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5aa00b2a45ed [wpt PR 39750] - [GridNG] Handle opposite writing direction subgrids, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.