1829903 - [wpt-sync] Sync PR 39692 - [RemoveLegacy] Fix crash at subtree root without layout-result.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39692 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39692
Details from upstream follow.

Ian Kilpatrick <[e-mail]> wrote:

[RemoveLegacy] Fix crash at subtree root without layout-result.

It was possible (with fieldsets) to layout at a subtree root which
didn't undergo layout previously (due to the way children are created).

Check that we have a previous layout result before selecting the subtree
root.

This is due to the new LayoutNewSubtreeRoot logic, and hence added it
under that flag.

Fixed: 1439692
Change-Id: I54eab45b213616f0ad174fbdf0d6cdaf8916c8e0
Reviewed-on: https://chromium-review.googlesource.com/4472060
WPT-Export-Revision: c8bb5695c40a8f0906791a0c6d1e7505c7cb8195

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6798d6fd47d70844ef63e90d25e02e3c338f4b37

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Try push failed: decision task VVdetU_AQJaVIi_lCftNzg returned error

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=54f4801a79105b5ecb1a4e6e0e95d87dd4cda6aa

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7dd44eeb342
[wpt PR 39692] - [RemoveLegacy] Fix crash at subtree root without layout-result., a=testonly

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f7dd44eeb342