1828469 - Display StaticRanges in custom highlights

Status: RESOLVED FIXED

(Core :: DOM: Selection, task)

Description

[Jan Jaeschke [:jjaschke]]

Currently StaticRanges of custom highlights are not painted. This is due to nsINode::IsSelected() not taking them into account and returning false. This should be solvable by moving some logic from nsRange to AbstractRange.

Comment 1

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1828469, part 2: Moved some logic from `nsRange` to `AbstractRange` to support `StaticRange`s in custom highlights. r=masayuki!

With this change, Selections are also registered into StaticRanges,
ultimately making them visible to nsINode::IsSelected(),
which is necessary to paint them.

Comment 2

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1828469, part 1: Prepare `RangeBoundaryBase` to be able to handle non-`MutationObserver` Range classes. r=masayuki!

In order to support StaticRanges, which are not MutationObservers, RangeBoundaries need to have an alternative way of ensuring that mRef points to the correct node.
This is now done by validating mRef every time Ref() is called using the parent and offset.
For performance reasons, this is disabled by default and should only be used for StaticRanges.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c78c717e4ec9
part 1: Prepare `RangeBoundaryBase`  to be able to handle non-`MutationObserver` Range classes. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/217801294c41
part 2: Moved some logic from `nsRange` to `AbstractRange` to support `StaticRange`s in custom highlights. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/ab92a12ba6ea
apply code formatting via Lando

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out 3 changesets (Bug 1828469) for causing assertion in RangeBoundary.h

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=XMGqk6a2QJ6PC9ilXM2gqQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=ab92a12ba6eaa95e1bb5f30a773d621c88037589

Log: https://treeherder.mozilla.org/logviewer?job_id=416686748&repo=autoland&lineNumber=13518
Crashtests: https://treeherder.mozilla.org/logviewer?job_id=416687272&repo=autoland&lineNumber=6648

Backout: https://hg.mozilla.org/integration/autoland/rev/70a155709dde9d2f0a44362e8841757244b86928

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1014972dcb6
part 1: Prepare `RangeBoundaryBase`  to be able to handle non-`MutationObserver` Range classes. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/d1863c09bc4e
part 2: Moved some logic from `nsRange` to `AbstractRange` to support `StaticRange`s in custom highlights. r=masayuki

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b1014972dcb6
https://hg.mozilla.org/mozilla-central/rev/d1863c09bc4e