1824433 - Do not print an error when trying to get the CookieJarSettings for TRRServiceChannel

Status: RESOLVED FIXED

(Core :: Security, enhancement)

Description

[Tom Ritter [:tjr]]

I was seeing tons and tons of these logs:

[Parent 985951, TRR Background] WARNING: 'NS_FAILED(rv)', file /home/tom/Documents/moz/mozilla-unified-5/dom/base/nsContentUtils.cpp:2187
[Parent 985951, TRR Background] WARNING: 'NS_FAILED(rv)', file /home/tom/Documents/moz/mozilla-unified-5/dom/base/nsContentUtils.cpp:2187
[Parent 985951, TRR Background] WARNING: 'NS_FAILED(rv)', file /home/tom/Documents/moz/mozilla-unified-5/dom/base/nsContentUtils.cpp:2187
[Parent 985951, TRR Background] WARNING: 'NS_FAILED(rv)', file /home/tom/Documents/moz/mozilla-unified-5/dom/base/nsContentUtils.cpp:2187
[Parent 985951, TRR Background] WARNING: 'NS_FAILED(rv)', file /home/tom/Documents/moz/mozilla-unified-5/dom/base/nsContentUtils.cpp:2187

And traced it back to trying to retrieve the CookieJarSettings on the TRRLoadInfo.

We can be a bit more intelligent and not spam this warning.

Comment 1

[Dana Keeler (she/her) [:keeler]]

(sorry for the noise)

Comment 2

[Tom Ritter [:tjr]]

Attachment: Bug 1824433: Handle TRRServiceChannel in ShouldResistFingerprinting r?timhuang,evilpie

If the CookieJarSettings is not implemented, return false.

Also, change the error behavior to also return false - we
don't need to immediately return true on error here, because
it may be the case that something else indicates we should not
Resist Fingerprinting (e.g. maybe the TRR connection is to an
exempted domain.)

Because we are no longer returning early, we need to check if
principal is null, as sometimes it might be now.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77de67657791
Handle TRRServiceChannel in ShouldResistFingerprinting r=timhuang,tschuster

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/77de67657791