Closed Bug 1823719 Opened 3 years ago Closed 3 years ago

Convert toolkit/components/remotebrowserutils to ES modules

Categories

(Core :: DOM: Navigation, task)

task

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: standard8, Assigned: kisavi, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [esmification-timeline][lang=js])

Attachments

(1 file)

I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it - please respect other contributors comments as well. You'll be automatically assigned when you upload the first patches.

Here's what to do:

  • Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
  • Using the ESMification walkthrough as a guide:
    1. Run ./mach esmify --convert path/to/files
    2. Examine the output for any errors from ESLint and fix them.
    3. Next convert the imports - ./mach esmify --import . --prefix path/to/files
    4. Again, check for any errors and fix them.
    5. Run a build to check it passes.
    6. Also run ./mach eslint --fix path/to/files and check there are no raised failures
    7. Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
  • Use moz-phab submit to submit the patches for review.

Hello @standard8. I am looking into the bug and have started working on it.

Assignee: nobody → deniskisavi
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/735b73193dc6 Convert toolkit/components/remotebrowserutils to ES modules. r=Standard8.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Duplicate of this bug: 1824607
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: