1823710 - Convert toolkit/components/captivedetect to ES modules

Status: RESOLVED FIXED

(Core :: Networking, task, P3)

Description

[Mark Banner (:standard8)]

I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it - please respect other contributors comments as well. You'll be automatically assigned when you upload the first patches.

Here's what to do:

• Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
  • If you need help setting up, ask in #introduction on Matrix
• Using the ESMification walkthrough as a guide:
  1. Run ./mach esmify --convert path/to/files
  2. Examine the output for any errors from ESLint and fix them.
  3. Next convert the imports - ./mach esmify --import . --prefix path/to/files
  4. Again, check for any errors and fix them.
  5. Run a build to check it passes.
  6. Also run ./mach eslint --fix path/to/files and check there are no raised failures
  7. Check for any documentation/comment changes, e.g. see this link
  8. Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
• Use moz-phab submit to submit the patches for review.

Comment 1

[Ebilite Uchenna]

Attachment: Bug 1823710 - Converted toolkit/components/captivedetect to ES modules. r?Standard8!

Comment 2

[Ebilite Uchenna]

Hello standard8, submitted a new patch on this task will love if it will be reviewed and corrected.

Comment 3

[Mark Banner (:standard8)]

Thank you, I will look at it tomorrow. No need to needinfo me here, I automatically get notified about the patch.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56c29cb58ae2
Converted toolkit/components/captivedetect to ES modules. r=Standard8

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/56c29cb58ae2