1822011 - Convert toolkit/components/urlformatter to ES modules

Status: RESOLVED FIXED

(Toolkit :: General, task, P3)

Description

[Mark Banner (:standard8)]

I'm happy to mentor work towards this bug. Please don't ask to be assigned to it, though you can say you're working on it - please respect other contributors comments as well. You'll be automatically assigned when you upload the first patches.

Here's what to do:

• Make sure you have a local build of Firefox up and running. Use these instructions if you haven't already.
  • If you need help setting up, ask in #introduction on Matrix
• Using the ESMification walkthrough as a guide:
  1. Run ./mach esmify --convert path/to/files
  2. Examine the output for any errors from ESLint and fix them.
  3. Next convert the imports - ./mach esmify --import . --prefix path/to/files
  4. Again, check for any errors and fix them.
  5. Run a build to check it passes.
  6. Also run ./mach eslint --fix path/to/files and check there are no raised failures
  7. Commit the changes with a commit messages such as "Bug nnnnnn - Convert path/to/files to ES modules. r?Standard8"
• Use moz-phab submit to submit the patches for review.

Comment 1

[Ganna]

Hi, I am the Outreachy applicant and I would like to work on this issue

Comment 2

[Mark Banner (:standard8)]

(In reply to Ganna from comment #1)

Hi, I am the Outreachy applicant and I would like to work on this issue

Hi, please see the start of comment 0 - you can start working on it without it being assigned, if no-one else has already commented on it.

Comment 3

[Ganna]

Attachment: Bug 1822011 - Convert toolkit/components/urlformatter to ES modules r?Standard8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3cb867a34b2
Convert toolkit/components/urlformatter to ES modules r=Standard8

Comment 5

[Ganna]

I know that this bug is closed, but I've got a question. After pulling central branch today and updating to it, hg status shows urlformatter file as not tracked
https://paste.mozilla.org/txRZDQPO
What should I do to prevent issues with my future patches?

Comment 6

[Mark Banner (:standard8)]

(In reply to Ganna from comment #5)

I know that this bug is closed, but I've got a question. After pulling central branch today and updating to it, hg status shows urlformatter file as not tracked
https://paste.mozilla.org/txRZDQPO
What should I do to prevent issues with my future patches?

Hmm, I'm not quite sure why that is and unfortunately the paste has expired. Try asking on the #introduction channel on matrix - if you can change the paste expiry to a week and re-paste it, then someone on the channel should be able to help you.

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/b3cb867a34b2